NOAA-EDAB / ecodata

A data package for reporting on Northeast Continental Shelf ecosystem status and trends.
https://noaa-edab.github.io/ecodata/
Other
28 stars 11 forks source link

Update existing and add new ecodata datasets #109

Closed BBeltz1 closed 6 months ago

BBeltz1 commented 6 months ago

The following datasets were added or updated:

BBeltz1 commented 6 months ago

@andybeet batch of ecodata corrections and updates needs review. let me know if you find any issues. Kim's new annual_chl_pp indicator will need a new plot function.

andybeet commented 6 months ago

what is the rationale for a new indicator (annual_chl_pp)? Could we have not added the new variables to the current `chl_pp' indicator? There is already an ANNUAL_PPD_MEDIAN. Why not add ANNUAL_PPD_MEAN and the other two variables?

BBeltz1 commented 6 months ago

The new indicator is the new data file that Kim H provided at this morning's stand up. I proposed the two options: include as new variables to the existing chl_pp indicator, OR create a new indicator to house the new variables. I believe Sarah and Kim chose the latter.

sgaichas commented 6 months ago

@andybeet we could have all the new stuff from Kim in the chl_pp dataset, but this was adding 4 new variables as I understood it, and all are annual instead of within year, so I thought it might be simpler/faster. I don't have strong opinions about this though so it could all be in one.

BBeltz1 commented 6 months ago

I will take a second look at wind_dev_speed now.

andybeet commented 6 months ago

i think we need to look at PP and CHL after the cycle. For now let's leave it

BBeltz1 commented 6 months ago

@sgaichas the variable names in wind_dev_speed are aligned with last year's submission, but this may be why year2023 did not appear in the plot for last report. I can rework these variable names to match 2021 and 2022, as well as fix the last year's 2023 variables so that years 2023 and 2024 appear on this year's report.

sgaichas commented 6 months ago

for wind_dev_speed I get 3 report years, 21, 22, and 24, so either we are missing 2023 or the year naming conventions differed (21 and 22 data in 22 and 23 reports?). If there is a way to tell, I think we should also reconcile the Report_year field to be consistent.

> unique(ecodata::wind_dev_speed$Report_year)
[1] "year2021" "year2022" "year2024"
BBeltz1 commented 6 months ago

@sgaichas there were issues present last year that persisted through this year's submission as well. that is why only 2021 and 2022 were plotted previously. these issues should now be corrected and we should be able to plot all years that have data. note: Angela told me that each year, these data become more and more aggregated. you'll now find that when plotting this dataset, all years after 2025 have been aggregated... previously, they remained separated until 2030.