NOAA-EDAB / ecodata

A data package for reporting on Northeast Continental Shelf ecosystem status and trends.
https://noaa-edab.github.io/ecodata/
Other
31 stars 12 forks source link

Short trend install #165

Closed BBeltz1 closed 2 weeks ago

BBeltz1 commented 2 weeks ago

Installed short term trend in the following plot functions:

*Datasets have missing years for some variables, which prevent short term trend analysis. These datasets will be corrected when updated for 2025. Plot functions have an added safeguard and will work as normal so long as variable n is not specified.

andybeet commented 2 weeks ago

All looks good other than plot_mab_inshore_survey. Seems like all fits are commented out. Is there a reason for that?

BBeltz1 commented 2 weeks ago

I did not comment out geom_gls, it was already commented out. So when I added geom_lm, I commented it out for consistency. I wanted to find out why geom_gls was turned off before turning either on.

andybeet commented 2 weeks ago

ok. sounds good.

Adding an additional argument, like we have done, is going to affect catalog i think. The make_rmd uses the number of arguments and/or the attributes (see here). We may need to take a look at this. Could also result in editing the attributes in each of the plot functions

andybeet commented 2 weeks ago

Also, this is just a subset of the plot functions. Is that because these are the only ones that are a line graph?

BBeltz1 commented 2 weeks ago

Yes it's a subset, I wanted to prioritize this installation to the plot functions that are actively using geom_gls.