search

NOAA-EDAB / survdat

https://noaa-edab.github.io/survdat/
https://noaa-edab.github.io/survdat/
Other
2 stars 1 forks source link

Sean #11

Closed slucey closed 3 years ago

slucey commented 3 years ago

Here are the updated functions with roxygen parameters updated as well. Will still need to run through the examples and probably update the vignettes.

andybeet commented 3 years ago

The function all_of isn't found. If it is part of a package which survdat already depends on then let's reference it by the package name. If we need to add another package dependency, lets do that, but if this is the only function used from a new dependent package, then i think we can rewrite this line. Do we need that function at all? Isn't areaDescription always a single column in the sf object

slucey commented 3 years ago

@andybeet I can't find the all_of function in the code and don't even remember using it. Which function is it in? Also, areaDescription should always be a single column. Is there somewhere where it is referencing more than one column?

slucey commented 3 years ago

Removed all_of ... seems to still work.

slucey commented 3 years ago

Fixed the if statement

andybeet commented 3 years ago

@slucey looks good.