NOAA-EMC / AQM

GNU General Public License v3.0
3 stars 18 forks source link

Modify UPP to post-process model's hourly-averaged O3 and PM2.5 #26

Closed JianpingHuang-NOAA closed 1 year ago

JianpingHuang-NOAA commented 2 years ago

1) comment out to delete the calculation of PM2.5 from the UPP 2) allow UPP to convert hourly-averaged O3 and PM2.5 data format from netcdf to grib2.

JianpingHuang-NOAA commented 2 years ago

The AQM v7.0 output files for 20190801 12z cycle can be found on Cactus

/lfs/h2/emc/physics/noscrub/jianping.huang/data/aqm.v7.0.c4/2019080112

KaiWang-NOAA commented 2 years ago

@JianpingHuang-NOAA @HaixiaLiu-NOAA For 1), As suggested by Wen Meng, in my current modified UPP code, I'm keeping the PM2.5 calculation as a legacy code and have added a switch to handle the new average PM2.5 field by skipping the PM2.5 calculation. For 2), the UPP code has been modified to convert hourly-average O3 and PM2.5 data from netcdf to grib2. Some final tuning is needed before the code to be ready.

KaiWang-NOAA commented 1 year ago

@HaixiaLiu-NOAA @JianpingHuang-NOAA An PR (https://github.com/NOAA-EMC/UPP/pull/591) created by @WenMeng-NOAA is pending for final confirmation of variable names for hourly average O3 and PM2.5. Once this is updated, I think the code should be ready for commitment.

JianpingHuang-NOAA commented 1 year ago

Kai ang Weng,

Can you test UPF with C20 output files?

/lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c20.20221127/06

Jianping

On Thu, Dec 1, 2022 at 1:55 PM KaiWang-NOAA @.***> wrote:

@HaixiaLiu-NOAA https://github.com/HaixiaLiu-NOAA @JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA An PR (NOAA-EMC/UPP#591 https://github.com/NOAA-EMC/UPP/pull/591) created by @WenMeng-NOAA https://github.com/WenMeng-NOAA is pending for final confirmation of variable names for hourly average O3 and PM2.5. Once this is updated, I think the code should be ready for commitment.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1334206703, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI2TQIFXTMS5OAUQVW3WLDYDDANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA

/lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c20.20221127/06 Any model output changed in your C20 test?

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***> For 3-D array, we are going to output 4 chemical species o3_ave no_ave no2_ave pm25_ave

In addition, we also write out AOD as a 2D variable

More details can be found from diag_table_aqm.FV3_GFS_v16 at

/lfs/h2/emc/physics/noscrub/jianping.huang/nwdev/packages/aqm.v7.0.20/parm (Cactus)

On Thu, Dec 1, 2022 at 7:28 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA

/lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c20.20221127/06 Any model output changed in your C20 test?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1334615612, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6LOTFYF3AJZOFXBTDWLE7EHANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA I ran my working branch post_aqm with the model files C20. The test results are at /u/wen.meng/ptmp/post_aqm_2022112706 on cactus.

My branch is available at the UPP PR queue at https://github.com/NOAA-EMC/UPP/pull/591

The UPP only read in pm25_ave and o3_ave right now. Please let me know if you would like to read in additional variables for AQM V7 implementation.

JianpingHuang-NOAA commented 1 year ago

Hi Wen,

Sorry for the late response. I checked the grib2 file (CMAQ60.tm00 at your test dit) but I saw O3MR. Can you add AOD since the verification team and other users like NESDIS ask for it? In addition, can you remove O3MR since it isn't included in our output list?

@Chan-Hoo Jeon - NOAA Affiliate @.> @Kai Wang - NOAA Affiliate @.>

Can you have a double check?

In addition, our model output files can be found at /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c20.20221127/06.

aqm.t06z.dyn for 3d and aqm.t06z.phy for 2d variables.

Thanks,

Jianping

On Fri, Dec 2, 2022 at 9:33 AM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA I ran my working branch post_aqm with the model files C20. The test results are at /u/wen.meng/ptmp/post_aqm_2022112706 on cactus.

My branch is available at the UPP PR queue at NOAA-EMC/UPP#591 https://github.com/NOAA-EMC/UPP/pull/591

The UPP only read in pm25_ave and o3_ave right now. Please let me know if you would like to read in additional variables for AQM V7 implementation.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335321327, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI3KCKUD3UZYUBBCS6LWLICEFANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

JianpingHuang-NOAA commented 1 year ago

I should include @Ho-Chun Huang @.***> , not Chan-Hoo. Sorry for that.

On Fri, Dec 2, 2022 at 3:30 PM Jianping Huang - NOAA Affiliate < @.***> wrote:

Hi Wen,

Sorry for the late response. I checked the grib2 file (CMAQ60.tm00 at your test dit) but I saw O3MR. Can you add AOD since the verification team and other users like NESDIS ask for it? In addition, can you remove O3MR since it isn't included in our output list?

@Chan-Hoo Jeon - NOAA Affiliate @.> @Kai Wang - NOAA Affiliate @.>

Can you have a double check?

In addition, our model output files can be found at /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c20.20221127/06.

aqm.t06z.dyn for 3d and aqm.t06z.phy for 2d variables.

Thanks,

Jianping

On Fri, Dec 2, 2022 at 9:33 AM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA I ran my working branch post_aqm with the model files C20. The test results are at /u/wen.meng/ptmp/post_aqm_2022112706 on cactus.

My branch is available at the UPP PR queue at NOAA-EMC/UPP#591 https://github.com/NOAA-EMC/UPP/pull/591

The UPP only read in pm25_ave and o3_ave right now. Please let me know if you would like to read in additional variables for AQM V7 implementation.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335321327, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI3KCKUD3UZYUBBCS6LWLICEFANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA What's your suggestion for grib2 name of AOD?

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***> I am checking the operational product for aot /lfs/h1/ops/prod/com/aqm/v6.1/cs.20221202 > degrib2 aqm.t00z.aot.f01.148.grib2

PRODUCT TEMPLATE 4. 46: ( PARAMETER = AOTK 0 20 102 ) 20 102 0 0 0 0 0 0 2 0 211 0 0 1 0 104 4 10000 255 0 0 2022 12 2 1 0 0 1 0 0 2 1 1 255 0 FIELD: AOTK 1 sigma (0 -1 hr ) valid 0 hour after 2022120200:00:00 to 2022120201:00:00

Can we use the same variable? @Ho-Chun Huang @.***> What is your suggestion?

On Fri, Dec 2, 2022 at 3:38 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA What's your suggestion for grib2 name of AOD?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335818491, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6IHXTC2MHQG2RU57DWLJM4PANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

JianpingHuang-NOAA commented 1 year ago

Hi, Jianping:

Keeping the same name is preferred, otherwise, we need to inform Perry on the new name for his EVS development.

Ho-Chun Huang, Ph.D.

Physical Scientist III, Contractor with Lynker in Support of

NOAA/NWS/NCEP/EMC, U.S. Department of Commerce

5830 University Research Ct., Rm. 2792

College Park, MD 20740

@. @.>

301-683-3958

On Fri, Dec 2, 2022 at 3:44 PM Jianping Huang - NOAA Affiliate < @.***> wrote:

@Wen Meng - NOAA Federal @.***> I am checking the operational product for aot /lfs/h1/ops/prod/com/aqm/v6.1/cs.20221202 > degrib2 aqm.t00z.aot.f01.148.grib2

PRODUCT TEMPLATE 4. 46: ( PARAMETER = AOTK 0 20 102 ) 20 102 0 0 0 0 0 0 2 0 211 0 0 1 0 104 4 10000 255 0 0 2022 12 2 1 0 0 1 0 0 2 1 1 255 0 FIELD: AOTK 1 sigma (0 -1 hr ) valid 0 hour after 2022120200:00:00 to 2022120201:00:00

Can we use the same variable? @Ho-Chun Huang @.***> What is your suggestion?

On Fri, Dec 2, 2022 at 3:38 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA What's your suggestion for grib2 name of AOD?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335818491, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6IHXTC2MHQG2RU57DWLJM4PANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA and @Ho-ChunHuang-NOAA Are these ops. aqm.t00z.aot.f01.148.grib2 files generated from UPP or other applications?

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***> It is generated by other post code, not UPP.

On Fri, Dec 2, 2022 at 4:18 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA and @Ho-ChunHuang-NOAA https://github.com/Ho-ChunHuang-NOAA Are these ops. aqm.t00z.aot.f01.148.grib2 files generated from UPP or other applications?

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335853294, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI5OBNNCX7CJ2RV6QR3WLJRR3ANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

/lfs/h1/ops/prod/com/aqm/v6.1/cs.20221202

wen.meng@clogin01 cs.20221202$ wgrib2 aqm.t06z.aot.f04.148.grib2
1:0:d=2022120206:AOTK:1 sigma level:3-4 hour ave fcst:aerosol=Ozone:aerosol_size <0

Would you keep vertical level as "1 sigma level" (which might not be consistent with model output), or others, e.g. "entire atmosphere"? A new UPP ID definition is needed for output this field. @JianpingHuang-NOAA

JianpingHuang-NOAA commented 1 year ago

It is fine to keep it the same as the operational one since AOD is not an operational product and doesn't need to add a WMO header this time.

On Fri, Dec 2, 2022 at 5:22 PM WenMeng-NOAA @.***> wrote:

/lfs/h1/ops/prod/com/aqm/v6.1/cs.20221202

@.*** cs.20221202$ wgrib2 aqm.t06z.aot.f04.148.grib2 1:0:d=2022120206:AOTK:1 sigma level:3-4 hour ave fcst:aerosol=Ozone:aerosol_size <0

Would you keep vertical level as "1 sigma level" (which might not be consistent with model output), or others, e.g. "entire atmosphere"? A new UPP ID definition is needed for output this field. @JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1335921563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6DP4W7HT3KFA4GWITWLJZC7ANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

HaixiaLiu-NOAA commented 1 year ago

From Kai:

An PR was opened (PR #591) by Wen. Tests have been done for the new runs from Jianping and should be ready for commit anytime soon

WenMeng-NOAA commented 1 year ago

@HaixiaLiu-NOAA @JianpingHuang-NOAA I would like to know the timeline of freezing code for AQM V7 implementation. More effort is needed regarding Jinping's new request. From UPP code management side, there might be a week for processing a PR in the repository.

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***> It will be great if you can get this ready by Dec. 10.

On Sat, Dec 3, 2022 at 10:22 AM WenMeng-NOAA @.***> wrote:

@HaixiaLiu-NOAA https://github.com/HaixiaLiu-NOAA @JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA I would like to know the timeline of freezing code for AQM V7 implementation. More effort is needed regarding Jinping's new request. From UPP code management side, there might be a week for processing a PR in the repository.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1336181905, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI2MM62XWYPKOL7TBLTWLNQTHANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

JianpingHuang-NOAA commented 1 year ago

@WenMeng-NOAA Doe it include AOD and PBLH now? @Ho-ChunHuang-NOAA

WenMeng-NOAA commented 1 year ago

It is fine to keep it the same as the operational one since AOD is not an operational product and doesn't need to add a WMO header this time. On Fri, Dec 2, 2022 at 5:22 PM WenMeng-NOAA @.> wrote: /lfs/h1/ops/prod/com/aqm/v6.1/cs.20221202 @. cs.20221202$ wgrib2 aqm.t06z.aot.f04.148.grib2 1:0:d=2022120206:AOTK:1 sigma level:3-4 hour ave fcst:aerosol=Ozone:aerosol_size <0 Would you keep vertical level as "1 sigma level" (which might not be consistent with model output), or others, e.g. "entire atmosphere"? A new UPP ID definition is needed for output this field. @JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6DP4W7HT3KFA4GWITWLJZC7ANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

@JianpingHuang-NOAA I think that's a bad idea for marking variables at non-sigmal levels as sigma levels in UPP code. That could mislead other UPP developers. I would suggest to output this field as:

AOTK:entire atmosphere:3-4 hour ave fcst:aerosol=Ozone:aerosol_size <0

I can generate some sample data files for Perry's evaluating any updates of his verification package. Or you may use wgrib2 utility to change veridical levels for your preference in AQM workflow scripts. Let me know your thoughts.

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA I can't do any changes due to Cactus is in maintenance.

JianpingHuang-NOAA commented 1 year ago

ok

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA A sample of wgrib2 option for changing vertical level label can be found as:

(13) My software won't handle the level "30-0 mb above ground".  How do
     I change the level to "15 mb above ground"?

     old style IF structure
     wgrib2 in.grb -if ":30-0 mb above ground" -set_lev "15 mb above ground"
          -fi -grib out.grb

     new style IF structure (wgrib2 v3.0.0+)
     wgrib2 in.grb -if ":30-0 mb above ground" -set_lev "15 mb above ground"
          -endif -grib out.grb
WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA and @Ho-ChunHuang-NOAA Is PBL height generated in the current ops. products? Please provide me the sample file.

HaixiaLiu-NOAA commented 1 year ago

@JianpingHuang-NOAA @Ho-ChunHuang-NOAA can you answer above question from @WenMeng-NOAA ? Is PBL height one of the current operation product variables? Thanks.

WenMeng-NOAA commented 1 year ago

Please see my latest test from the comments of the UPP PR #591

Ho-ChunHuang-NOAA commented 1 year ago

Haixia:

I talked to Wen on Tuesday in the office about this.

Ho-Chun Huang, Ph.D.

Physical Scientist III, Contractor with Lynker in Support of

NOAA/NWS/NCEP/EMC, U.S. Department of Commerce

5830 University Research Ct., Rm. 2792

College Park, MD 20740

@. @.>

301-683-3958

On Wed, Dec 7, 2022 at 3:07 PM HaixiaLiu @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA @Ho-ChunHuang-NOAA https://github.com/Ho-ChunHuang-NOAA can you answer this question from @WenMeng-NOAA https://github.com/WenMeng-NOAA ? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1341527237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHE3EC4YFPQIGSNMWETL3WMDU7DANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

HaixiaLiu-NOAA commented 1 year ago

Thanks, @Ho-ChunHuang-NOAA @WenMeng-NOAA It is almost ready to be merged. I noticed Kai had approved the changes

JianpingHuang-NOAA commented 1 year ago

I saw that PBLH is included in the latest grib2 file provided by Wen.

@Ho-Chun Huang @.> @Haixia Liu - NOAA Affiliate @.>

On Wed, Dec 7, 2022 at 3:07 PM HaixiaLiu @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA @Ho-ChunHuang-NOAA https://github.com/Ho-ChunHuang-NOAA can you answer this question from @WenMeng-NOAA https://github.com/WenMeng-NOAA ? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1341527237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PIZMVJ4DMGJNC6BMKTDWMDU7DANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

I have been waiting for AQM team to verify these new output fields PBLH and hourly aod so I can commit the changes in my UPP working branch for AQM V7.

HaixiaLiu-NOAA commented 1 year ago

@Ho-ChunHuang-NOAA @JianpingHuang-NOAA Do the PBLH and AOD fields generated from UPP look good to you? Please advise Wen whether she should merge the changes into her authoritative branch. Thanks.

Ho-ChunHuang-NOAA commented 1 year ago

I answer the question in PR#591 email

Hi,

using /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c22.20221206/06/aqm.t06z.cmaq.f###.793.grib2 ?

I saw 577:112927127:vt=2022120906:surface:72 hour fcst:PBLREG Planetary Boundary Layer Regime [-]:

I did not see AOTK or AOD.

Ho-Chun Huang, Ph.D.

Physical Scientist III, Contractor with Lynker in Support of

NOAA/NWS/NCEP/EMC, U.S. Department of Commerce

5830 University Research Ct., Rm. 2792

College Park, MD 20740

@. @.>

301-683-3958

On Thu, Dec 8, 2022 at 10:57 AM HaixiaLiu @.***> wrote:

@Ho-ChunHuang-NOAA https://github.com/Ho-ChunHuang-NOAA @JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA Do the PBLH and AOD fields generated from UPP look good to you? Please advise Wen whether she should merge the changes into her authoritative branch. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1342941009, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHE3BS52N6J3XZB5IIRUDWMIAMVANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***>

Can you do a test with your UPP on our latest NRTC22 on Cactus at

/lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c22.20221207/06

?

Thanks,

Jianping

On Thu, Dec 8, 2022 at 10:47 AM WenMeng-NOAA @.***> wrote:

I have been waiting for AQM team to verify these new output fields PBLH and hourly aod so I can commit the changes in my UPP working branch for AQM V7.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1342929355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PIY5C33PPCYQOGMRAN3WMH7JFANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA The UPP test with model files c22 from /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c22.20221207/06 is already at /u/wen.meng/ptmp/post_aqm_2022120606-c22

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.> It looks for me. @Ho-Chun Huang @.> Can you have a check and see whether it includes all parameters you need for verification?

On Thu, Dec 8, 2022 at 1:07 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA The UPP test with model files c22 from /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c22.20221207/06 is already at /u/wen.meng/ptmp/post_aqm_2022120606-c22

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1343106457, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI2XYSBDJSDAXPI5WXDWMIPWTANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

Ho-ChunHuang-NOAA commented 1 year ago

@JianpingHuang-NOAA @HaixiaLiu-NOAA @WenMeng-NOAA I am not the right person to check files in /u/wen.meng/ptmp/post_aqm_2022120606-c22. I have no knowledge of what they are

JianpingHuang-NOAA commented 1 year ago

@Ho-Chun Huang @.***> I thought you are the key person doing AQ verification.

@Wen Meng - NOAA Federal @.***> Is it possible to adde NO and NO2 in the UPP? . They are not operational products but one of the key precursors of O3 formation. Sorry for the late asking. Thanks !

On Thu, Dec 8, 2022 at 2:57 PM Ho-Chun Huang @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA @HaixiaLiu-NOAA https://github.com/HaixiaLiu-NOAA @WenMeng-NOAA https://github.com/WenMeng-NOAA I am not the right person to check files in /u/wen.meng/ptmp/post_aqm_2022120606-c22. I have no knowledge of what they are

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1343279394, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI4JQV2RGYWTTTMVLLDWMI4SHANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

Ho-ChunHuang-NOAA commented 1 year ago

@JianpingHuang-NOAA @HaixiaLiu-NOAA @WenMeng-NOAA I am using g793 grib2 files output in your run output directory for verification. I do not know any of the files in /u/wen.meng/ptmp/post_aqm_2022120606-c22.

Youi should run your post producing grib2 files for verification of both o3/pm or meteorological variable.

WenMeng-NOAA commented 1 year ago

Is it possible to adde NO and NO2 in the UPP? . They are not operational products but one of the key precursors of O3 formation. Sorry for the late asking. Thanks !

I am not familiar the appropriate grib2 names for NO and NO2. Can anyone from AQM team check grib2 table and UPP code if these fields are available? @JianpingHuang-NOAA

HaixiaLiu-NOAA commented 1 year ago

@JianpingHuang-NOAA can we check on this and provide feedback to @WenMeng-NOAA so that she can merge the UPP changes? Thanks much

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***> Since we are using template for AQM product generation, I did not find NO and NO2 in the table

https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-14.shtml

Can we add 204 for NO and 205 for NO2? Or do we need to get approval of the new variables? Hi Andrew, do you have any suggestions on that? @Andrew Benjamin - NOAA Federal @.***>

On Fri, Dec 9, 2022 at 10:49 AM HaixiaLiu @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA can we check on this and provide feedback to @WenMeng-NOAA https://github.com/WenMeng-NOAA so that she can merge the UPP changes? Thanks much

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1344467307, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI76HGYJKGXCSSE3FTLWMNIINANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

JianpingHuang-NOAA commented 1 year ago

Jianping,

You are going to have to be more specific, I have no background as to what you are doing.

You would like to add NO and NO2 to the NCEP grib2 tables? And you would like them to be defined as local use? Are these fields already being used elsewhere? Are these new fields going into the new AQM model?

What exactly is NO and NO2? I am going to need their full names, units, and the abbreviation to be used in the grib2 table if a similar product does not exist. Also I am guessing you are comfortable having this variable be an NCEP local use field?

Finally, if you click on the link provided, 204 has already been designated to ALD2.

On Fri, Dec 9, 2022 at 12:44 PM Jianping Huang - NOAA Affiliate < @.***> wrote:

@Wen Meng - NOAA Federal @.***> Since we are using template for AQM product generation, I did not find NO and NO2 in the table

https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-14.shtml

Can we add 204 for NO and 205 for NO2? Or do we need to get approval of the new variables? Hi Andrew, do you have any suggestions on that? @Andrew Benjamin - NOAA Federal @.***>

On Fri, Dec 9, 2022 at 10:49 AM HaixiaLiu @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA can we check on this and provide feedback to @WenMeng-NOAA https://github.com/WenMeng-NOAA so that she can merge the UPP changes? Thanks much

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1344467307, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI76HGYJKGXCSSE3FTLWMNIINANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Benjamin Physical Scientist Verification/Post-Processing/Product-Generation Verification Branch NOAA/NWS/NCEP/EMC

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA Given the code freezing for AQM V7 implementation date approaching, assigning new grib2 names might not be a good idea. A g2tmpl library upgrade will be involved. Based on our experience, it could take more than 4 months for library installation at prod side on WCOSS2. @HuiyaChuang-NOAA may chime in.

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.> Understood. We can do that during the next implementation. Thanks ! @Andrew Benjamin - NOAA Federal @.>

On Fri, Dec 9, 2022 at 3:48 PM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA Given the code freezing for AQM V7 implementation date approaching, assigning new grib2 names might not be a good idea. A g2tmpl library upgrade will be involved. Based on our experience, it could take more than 4 months for library installation at prod side on WCOSS2. @HuiyaChuang-NOAA https://github.com/HuiyaChuang-NOAA may chime in.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1344766343, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI7ARI65BO54DYMNDWDWMOLILANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA @KaiWang-NOAA The changes for aod and HPBL were committed. Please review the whole PR so I can proceed the merging process. The UPP test case can be found at /u/wen.meng/ptmp/post_aqm_2022112706 on dogwood. Thanks!

JianpingHuang-NOAA commented 1 year ago

@Wen Meng - NOAA Federal @.***>. Please send the link of the PR to me. Thanks !

On Mon, Dec 12, 2022 at 9:05 AM WenMeng-NOAA @.***> wrote:

@JianpingHuang-NOAA https://github.com/JianpingHuang-NOAA @KaiWang-NOAA https://github.com/KaiWang-NOAA The changes for aod and HPBL were committed. Please review the whole PR so I can proceed the merging process. The UPP test case can be found at /u/wen.meng/ptmp/post_aqm_2022112706 on dogwood. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/AQM/issues/26#issuecomment-1346567915, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2PI6MHV6TEIGYKNHVPKTWM4WLVANCNFSM6AAAAAARFKDM3I . You are receiving this because you were mentioned.Message ID: @.***>

WenMeng-NOAA commented 1 year ago

@JianpingHuang-NOAA See https://github.com/NOAA-EMC/UPP/pull/591

HaixiaLiu-NOAA commented 1 year ago

since the changes were merged into UPP. The issue can be closed @JianpingHuang-NOAA

JianpingHuang-NOAA commented 1 year ago

Done