Remove compiler warnings and remarks for AQMv7 implementation

rmontuoro commented 1 year ago

PR Checklist

[x] This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
- [ ] RDHPCS.
- [X] WCOSS2.
[x] This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.
[ ] New or updated input data is required by this PR.
[ ] Baselines are expected to change.

Description

Issue(s) addressed

This PR removes the compiler warnings referenced in Issue #93 and fixes edit descriptors in the original CMAQ source code leading to compiler remarks.

The changes included in this PR passed regression testing on Cactus.

Dependencies

None

JianpingHuang-NOAA commented 1 year ago

@rmontuoro Have you done any test on this PR?

BrianCurtis-NOAA commented 1 year ago

@JianpingHuang-NOAA can you please run AQM with these changes (if you haven't yet) to make sure the results are not changing. I don't expect them to. As soon as you confirm we can merge this.

JianpingHuang-NOAA commented 1 year ago

@BrianCurtis-NOAA I have done the test. Everything is good. Do we need to open a PR to merge the changes to the ufs-weather-model?

BrianCurtis-NOAA commented 1 year ago

@BrianCurtis-NOAA I have done the test. Everything is good. Do we need to open a PR to merge the changes to the ufs-weather-model?

We can bring these changes into the weather model later. I'll merge this in now.

NOAA-EMC / AQM