search

NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
0 stars 18 forks source link

Update CMEPS with upstream #109

Closed uturuncoglu closed 6 months ago

uturuncoglu commented 6 months ago

Description of changes

This PR aims to update CMPES with the upstream (ESCOMP) to bring recent developments such as CDEPS inline capability to UFS Weather Model.

Specific notes

Contributors other than yourself, if any: @DeniseWorthen @danrosen25 @binli2337 @BinLiu-NOAA

CMEPS Issues Fixed (include github issue #): N/A

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No

Any User Interface Changes (namelist or namelist defaults changes)?

The user need to add new phase (med_phases_cdeps_run) to the run sequence to activate the feature. Then, needs to provide stream.config configuration file.

Additional changes also made to allow filling exchange fields with all data in the first coupling time step. I introduce set of new mediator namelist option to make it configurable. So, for example I am setting following in the nems.configure for ocean and wave (in mediator section),

  ocn_use_data_first_import = .true.
  wav_use_data_first_import = .true.

By default the values are .false. and it is only usable when CDEPS Inline feature activated. I also modify the wave and ocean prep phases to get the data and pass it to the components.

Testing performed

Please describe the tests along with the target model and machine(s) If possible, please also added hashes that were used in the testing Both CESM (Derecho, Intel) and UFS Weather Model (Orion Intel and WCOSS2) head of develop tested on multiple machines.

BinLiu-NOAA commented 6 months ago

@DeniseWorthen and @uturuncoglu, Just a note: if PR #107 got merged into NOAA-EMC/CMEPS:emc/develop branch first, then most likely, you will need recreate this PR by using another feature branch (unless you can sync ESCOMP: main with the latest NOAA-EMC/CMEPS:emc/develop right after PR #107). Thanks!

BinLiu-NOAA commented 6 months ago

@DeniseWorthen and @uturuncoglu, since PR #107 is merged, I believe we need sync this PR branch with the latest NOAA-EMC:emc/develop branch. Otherwise, ufs-community/ufs-weather-model/pull/2028 RTs will fail during compiling.

Again, if ESCOMP:main can not be synced at this moment, then will need recreate this PR from another branch. Thanks!

DeniseWorthen commented 6 months ago

@uturuncoglu @BinLiu-NOAA It is ESCOMP's call here....it should be safe (since #107) only changed ufs side, but I defer to them.

uturuncoglu commented 6 months ago

@DeniseWorthen I think I could create new branch from ESCOMP and then merge this to it. Then, update the UFS level PR by pointing it. That will solve the problem. Then, when we have another PR in the ESCOMP CMEPS side, we could push these changes. Let me know what you think?

DeniseWorthen commented 6 months ago

@uturuncoglu That is fine.

uturuncoglu commented 6 months ago

@DeniseWorthen Closing this since we have updated branch and PR https://github.com/NOAA-EMC/CMEPS/pull/110