search

NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
0 stars 18 forks source link

Bugfix: update data type for use_2m_diagnostics_calculated_by_lake_model #119

Closed grantfirl closed 2 months ago

grantfirl commented 3 months ago

Description of changes

Fix the data type of one variable in MED_typedefs.meta. There was an error in the data type used in the physics and all host metadata. The datatype is LOGICAL in the actual FORTRAN code, but was listed as INTEGER in the metadata. This bug was fixed because the new version of the CCPP Framework actually compares metadata to the FORTRAN code.

Change is analogous to https://github.com/NOAA-EMC/fv3atm/pull/831

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): None

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Should be B4B. This is only a metadata change.

Any User Interface Changes (namelist or namelist defaults changes)?

No

Testing performed

Testing will be reported on in https://github.com/ufs-community/ufs-weather-model/pull/2264

jkbk2004 commented 2 months ago

@DeniseWorthen @uturuncoglu Can you review/approve this pr? We are going to start testing at https://github.com/ufs-community/ufs-weather-model/pull/2264

jkbk2004 commented 2 months ago

@DeniseWorthen @uturuncoglu All tests are done ok at https://github.com/ufs-community/ufs-weather-model/pull/2264. can you merge this pr?

uturuncoglu commented 2 months ago

@jkbk2004 I have no rights to merge this PR. So, probably @DeniseWorthen could do it.

BrianCurtis-NOAA commented 2 months ago

@DeniseWorthen is out all next week. Is there a backup for her here?

BrianCurtis-NOAA commented 2 months ago

@jkbk2004 all set here.