NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
0 stars 20 forks source link

incorrect mapping type for ifrac #17

Closed DeniseWorthen closed 3 years ago

DeniseWorthen commented 3 years ago

The field Si_ifrac being exported by CMEPS to the ATM is currently being mapped with maptype mapnstod_consf (non-frac) and mapconsf (frac_mode). This is inconsistent with the value expected by FV3 (which assumes that the ifrac imported is weighted by the whole atm grid cell). The fix is to map by mapnstod_consd for nems_orig and mapconsd for nems_frac in med_fraction_mod.F90. This fix will change all current baselines.

This fix will be implemented as through CMEPS PR #10. This PR implements other changes which are required for CESM budget calculations but do not affect the NEMS implementation.