NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
0 stars 18 forks source link

new clm lake variables #77

Closed SamuelTrahanNOAA closed 1 year ago

SamuelTrahanNOAA commented 1 year ago

Description of changes

This is part of a group of PRs that add the CLM Lake Model to ccpp-physics, fv3atm, and ufs-weather-model. The only changes in this PR are to update the mediator f90 and meta files to have the new variables needed to interface with ccpp-physics. The PRs are all drafts because the CLM Lake Model regression tests do not reproduce their control after a restart yet.

Specific notes

Contributors other than yourself, if any: none yet

CMEPS UFS Issues Fixed (include github issue #): https://github.com/ufs-community/ufs-weather-model/issues/1510

Are changes expected to change answers? no

Any User Interface Changes (namelist or namelist defaults changes)? no

Testing performed

The tests performed were the ufs-weather-model regression tests. I don't know how to run any of these other tests, but the code changes are only in areas that CMEPS doesn't use in any configurations, and in fact it doesn't even have code to use it yet.

Testing performed if application target is CESM:

Testing performed if application target is UFS-coupled:

Testing performed if application target is UFS-HAFS:

Hashes used for testing:

zach1221 commented 1 year ago

Testing is finished on PR #1509, and we are ready to begin merge process. @DeniseWorthen @BrianCurtis-NOAA could you merge this PR?

BrianCurtis-NOAA commented 1 year ago

I do not have merge permissions here.

jkbk2004 commented 1 year ago

All tests are done at https://github.com/ufs-community/ufs-weather-model/pull/1509. This pr can be merged.