NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
0 stars 18 forks source link

Modify CMEPS for ufsdev_ruclsm #84

Closed RatkoVasic-NOAA closed 1 year ago

RatkoVasic-NOAA commented 1 year ago

Description of changes

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

Testing performed if application target is UFS-coupled:

Testing performed if application target is UFS-HAFS:

Hashes used for testing:

DeniseWorthen commented 1 year ago

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

RatkoVasic-NOAA commented 1 year ago

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

No, I just followed https://github.com/ufs-community/ufs-weather-model/pull/1646#issuecomment-1483039232 Maybe I should change this to draft!?

DeniseWorthen commented 1 year ago

Thanks. We do need a PR if you are changing something in CMEPS.

So we need this change, but something else is also going on because the compile is still failing, right?

tanyasmirnova commented 1 year ago

After 3 more commits the problem with compiling with CMEPS is resolved.

SamuelTrahanNOAA commented 1 year ago

This PR needs to be merged so we can merge #1646 before the deadline.

jkbk2004 commented 1 year ago

@BrianCurtis-NOAA @junwang-noaa can you approve this pr and merge?