modify cmeps for correct signs from ATM

NOAA-EMC / CMEPS

NUOPC Community Mediator for Earth Prediction Systems

https://escomp.github.io/CMEPS/

0 stars 18 forks source link

modify cmeps for correct signs from ATM #97

Closed DeniseWorthen closed 11 months ago

DeniseWorthen commented 1 year ago

Description of changes

Removes custom merges required because ATM does not send correct sign or unit.

fixes #93
required by https://github.com/ufs-community/ufs-weather-model/pull/1807

junwang-noaa commented 1 year ago

I saw "hafs" mode is changed in med_phases_prep_atm_mod.F90, so the changes will impact HAFS?

DeniseWorthen commented 1 year ago

No, that change just removes an un-used feature. The hafs mode does not use the aoflux calculation. The only changes are to any test are the mediator restart files, because the fields have a swapped sign.

I actually plan to retest once more after today's CICE PR, just to verify nothing else changes.

zach1221 commented 11 months ago

Ok, @DeniseWorthen . I think we're ready to begin the merge process. Feel free to merge this sub-component PR when you're able.

As discussed on this morning's CM call, HYCOM has already been merged.