search

NOAA-EMC / EVS

12 stars 24 forks source link

subseasonal: Fix file checking for weekly and monthly average files #548

Closed malloryprow closed 1 week ago

malloryprow commented 1 week ago

There were two failures in operations on 9/16/2024 in the subseasonal grid2grid stats jobs (both gefs and cfs). The failure happened in weekly_osi_saf_file in ush/subseasonal/subseasonal_util.py. Things are getting crossed as the same list that is being looped over to check files and is the same that is removing items for when files don't exist. Some files are not actually being checked for their existence.

In addition to weekly_osi_saf, this style of file checking is happening in monthly_osi_saf_file, weekly_ghrsst_ospo_file, and monthly_ghrsst_ospo_file.

malloryprow commented 1 week ago

@ShannonShields-NOAA After the production switch tomorrow, would you like to do the changes and PR to get the changes into develop? That way we both coded the changes and are familiar what is going on? You can use the changes #549 for reference.

ShannonShields-NOAA commented 1 week ago

Of course! I can definitely do that. I'll keep you posted tomorrow of my progress, Shannon

On Tue, Sep 17, 2024 at 3:15 PM Mallory Row @.***> wrote:

@ShannonShields-NOAA https://github.com/ShannonShields-NOAA After the production switch tomorrow, would you like to do the changes and PR to get the changes into develop? That way we both coded the changes and are familiar what is going on? You can use the changes #549 https://github.com/NOAA-EMC/EVS/pull/549 for reference.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/EVS/issues/548#issuecomment-2356705025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP4MEUD5JRMJDI7AVHBTIKDZXB5VDAVCNFSM6AAAAABOLMJMAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWG4YDKMBSGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Shannon Shields SAIC at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm 2180 College Park, MD 20740 @.***

ShannonShields-NOAA commented 1 week ago

Mallory, I will get started on this PR for develop in a little bit (this afternoon). Still catching up after the switch, Shannon

On Tue, Sep 17, 2024 at 3:20 PM Shannon Shields - NOAA Affiliate < @.***> wrote:

Of course! I can definitely do that. I'll keep you posted tomorrow of my progress, Shannon

On Tue, Sep 17, 2024 at 3:15 PM Mallory Row @.***> wrote:

@ShannonShields-NOAA https://github.com/ShannonShields-NOAA After the production switch tomorrow, would you like to do the changes and PR to get the changes into develop? That way we both coded the changes and are familiar what is going on? You can use the changes #549 https://github.com/NOAA-EMC/EVS/pull/549 for reference.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/EVS/issues/548#issuecomment-2356705025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP4MEUD5JRMJDI7AVHBTIKDZXB5VDAVCNFSM6AAAAABOLMJMAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWG4YDKMBSGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Shannon Shields SAIC at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm 2180 College Park, MD 20740 @.***

-- Shannon Shields SAIC at NOAA/NWS/NCEP/EMC 5830 University Research Ct. Rm 2180 College Park, MD 20740 @.***