NOAA-EMC / EVS

12 stars 27 forks source link

feature/nwps_structure #583

Closed SamiraArdani-NOAA closed 1 month ago

SamiraArdani-NOAA commented 1 month ago

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.

This PR initializes the EVS-NWPS, one of the components of EVS that is planned to be added into EVS v2.0. In its final form, EVS-NWPS computes the statistical metrics for verification of nearshore waves and generates the real-time verification graphics. Please note that in this PR, only the "prep" and "stats" step are tested. This PR initializes the EVS-NWPS using forecast files for one WFO (hgx) in southern region. Other WFOs will be added in the future PRs.

Developer Questions and Checklist

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.

1- To test this PR, you need to run the driver script for "prep" and "stats" steps. 2- Clone my fork in your local and checkout branch feature/nwps_structure. 3- ln -s fix directory. 4- In COMIN, point to ${USER}. 5- Run the driver scripts for prep step located at: $EVS/dev/drivers/scripts/prep/nwps/jevs_nwps_wave_grid2obs_prep.sh 6- Run the driver script for stats step located at: $EVS/dev/drivers/scripts/stats/nwps/jevs_nwps_wave_grid2obs_stats.sh

PerryShafran-NOAA commented 1 month ago

@SamiraArdani-NOAA You have many GLWU file changes in this PR. Please remove them. This PR only relates to NWPS file changes.

@AndrewBenjamin-NOAA @malloryprow

SamiraArdani-NOAA commented 1 month ago

@PerryShafran-NOAA, Right. I noticed that. They were generated when I was trying to merge develop to this branch. I just received the conflict message along with another message that was saying to use "git add ...". So , I added and committed the changes. The conflict was resolved but those GLWU files changes (already merged to develop) were generated. Do you know how to get rid of those?

PerryShafran-NOAA commented 1 month ago

@SamiraArdani-NOAA The best way that I know how is to do the following:

1) Close this PR. 2) Start clean with the current version of develop. 3) Copy in only the files that you changed for nwps. You may need to create a brand new feature branch to do this. 4) Commit these changes. 5) File a new PR.

This will ensure we make things the cleanest without going through any difficult steps to add/subtract files from this PR and its feature branch.

SamiraArdani-NOAA commented 1 month ago

@PerryShafran-NOAA, Ok. I will do the steps, close this and submit a new PR.