Closed SamiraArdani-NOAA closed 1 month ago
@SamiraArdani-NOAA You have many GLWU file changes in this PR. Please remove them. This PR only relates to NWPS file changes.
@AndrewBenjamin-NOAA @malloryprow
@PerryShafran-NOAA, Right. I noticed that. They were generated when I was trying to merge develop to this branch. I just received the conflict message along with another message that was saying to use "git add ...". So , I added and committed the changes. The conflict was resolved but those GLWU files changes (already merged to develop) were generated. Do you know how to get rid of those?
@SamiraArdani-NOAA The best way that I know how is to do the following:
1) Close this PR. 2) Start clean with the current version of develop. 3) Copy in only the files that you changed for nwps. You may need to create a brand new feature branch to do this. 4) Commit these changes. 5) File a new PR.
This will ensure we make things the cleanest without going through any difficult steps to add/subtract files from this PR and its feature branch.
@PerryShafran-NOAA, Ok. I will do the steps, close this and submit a new PR.
Note to developers: You must use this PR template!
Description of Changes
This PR initializes the EVS-NWPS, one of the components of EVS that is planned to be added into EVS v2.0. In its final form, EVS-NWPS computes the statistical metrics for verification of nearshore waves and generates the real-time verification graphics. Please note that in this PR, only the "prep" and "stats" step are tested. This PR initializes the EVS-NWPS using forecast files for one WFO (hgx) in southern region. Other WFOs will be added in the future PRs.
Developer Questions and Checklist
Is this a high priority PR? If so, why and is there a date it needs to be merged by?
No
Do you have any planned upcoming annual leave/PTO?
No.
Are there any changes needed for when the jobs are supposed to run?
No.
[x] The code changes follow NCO's EE2 Standards.
[x] Developer's name is removed throughout the code and have used
${USER}
where necessary throughout the code.[x] References the feature branch for
HOMEevs
are removed from the code.[x] J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
[x] Jobs over 15 minutes in runtime have restart capability.
[x] If applicable, changes in the
dev/drivers/scripts
ordev/modulefiles
have been made in the correspondingecf/scripts
andecf/defs/evs-nco.def
?[x] Jobs contain the appropriate file checking and don't run METplus for any missing data.
[x] Code is using METplus wrappers structure and not calling MET executables directly.
[x] Log is free of any ERRORs or WARNINGs.
Testing Instructions
1- To test this PR, you need to run the driver script for "prep" and "stats" steps. 2- Clone my fork in your local and checkout branch feature/nwps_structure. 3- ln -s fix directory. 4- In COMIN, point to ${USER}. 5- Run the driver scripts for prep step located at: $EVS/dev/drivers/scripts/prep/nwps/jevs_nwps_wave_grid2obs_prep.sh 6- Run the driver script for stats step located at: $EVS/dev/drivers/scripts/stats/nwps/jevs_nwps_wave_grid2obs_stats.sh