Adjust column lists for METv12 beta5 and fix typos

GwenChen-NOAA commented 1 month ago

Description of Changes

This PR 1) adjust the column list of VL1L2, VAL1L2, and VCNT line types for METv12.0.0-beta5 update, and 2) fix a typo (enesmble) in Line 2 of JEVS_GLOBAL_ENS_PREP/STATS/PLOTS.

Developer Questions and Checklist

Is this a high priority PR? If so, why and is there a date it needs to be merged by? Yes.
Do you have any planned upcoming annual leave/PTO? No.
Are there any changes needed for when the jobs are supposed to run? No.
[X] The code changes follow NCO's EE2 Standards.
[X] Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
[X] References the feature branch for HOMEevs are removed from the code.
[X] J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
[ ] Jobs over 15 minutes in runtime have restart capability.
[X] If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
[X] Jobs contain the appropriate file checking and don't run METplus for any missing data.
[X] Code is using METplus wrappers structure and not calling MET executables directly.
[ ] Log is free of any ERRORs or WARNINGs.

Testing Instructions

(1) Set up jobs

symlink the EVS_fix directory locally as "fix"
In the plots driver scripts, edit the following environment variables:

HOMEevs - set to your test EVS directory COMIN - set to /lfs/h2/emc/vpppg/noscrub/emc.vpppg/${NET}_beta5/$evs_ver_2d

(2) Run jobs I suggest testing the following jobs:

jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.sh jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.sh jevs_global_ens_wave_grid2obs_plots.sh

malloryprow commented 1 month ago

For the future, work should be done in a feature branch that is created off of develop.

GwenChen-NOAA commented 1 month ago

For the future, work should be done in a feature branch that is created off of develop.

So, will I create a feature branch in my fork and request it to be merged into EVS/develop branch?

malloryprow commented 1 month ago

For the future, work should be done in a feature branch that is created off of develop.

So, will I create a feature branch in my fork and request it to be merged into EVS/develop branch?

Yup!

malloryprow commented 1 month ago

Jobs are done!

jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.o158385898 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.158385898.cbqs01

jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.o158385918 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.158385918.cbqs01

jevs_global_ens_wave_grid2obs_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_wave_grid2obs_plots.o158386025 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_wave_grid2obs_plots.158386025.cbqs01

GwenChen-NOAA commented 1 month ago

@malloryprow, I think you forgot to link the fix directory, so the logos disappeared on the plots. Otherwise, your test runs look good to me with only 8 days of stats.

malloryprow commented 1 month ago

Ah yes. I didn't link them correctly. The jobs run pretty quick so I re-ran just to be sure.

jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.o158385898 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_atmos_gefs_grid2grid_past31days_plots.158385898.cbqs01

jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.o158385918 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_atmos_gefs_grid2obs_past31days_plots.158385918.cbqs01

jevs_global_ens_wave_grid2obs_plots.sh

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/EVS/dev/drivers/scripts/plots/global_ens/jevs_global_ens_wave_grid2obs_plots.o158388892 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr589/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_wave_grid2obs_plots.158388892.cbqs01

GwenChen-NOAA commented 1 month ago

@malloryprow, the new runs look very good to me.

NOAA-EMC / EVS