NOAA-EMC / EVS

12 stars 27 forks source link

Screen GEFS grid2obs Aeronet file before ASCII2NC call Feature/aeronetasciifix #593

Closed Ho-ChunHuang-NOAA closed 1 month ago

Ho-ChunHuang-NOAA commented 1 month ago

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.

To avoid ERROR of corrupted input obs file, this code will screen input aeronet file for broken record (inconsistent columns per record) and write out record with consistent column number. The checked aeronet file will be used in the ASCII2NC conversion. Minor fix for sending email in the stats step for reduced GEFS grib2 files that can be corrupted (zero size) due to disk quota exceed. This is for emc parallel to spot something wrong in the prep step.

Developer Questions and Checklist

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.

For prep step ONLY

The corrupted aeroent file existed on VDATE=20241014 and in personal archived directory.

Add export DCOMINaeronet=/lfs/h2/emc/vpppg/noscrub/ho-chun.huang/dcom/prod/aeronet

in

/dev/drivers/scripts/prep/global_ens/jevs_global_ens_chem_grid2obs_prep.sh for TESTING ONLY

One should see message "DEBUG :: Line 4317 has different columns number 137 vs standard 113"

and no ERROR and WARNING message in the log

malloryprow commented 1 month ago

jevs_global_ens_chem_grid2obs_prep.sh - Bad Data

Ran with INITDATE=20241014 and DCOMINaeronet=/lfs/h2/emc/vpppg/noscrub/ho-chun.huang/dcom/prod/aeronet

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr593/EVS/dev/drivers/scripts/prep/global_ens/jevs_global_ens_chem_grid2obs_prep.o158973348 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr593/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_chem_grid2obs_prep.158973348.cbqs01

Ho-ChunHuang-NOAA commented 1 month ago

The log file looks good to me.

The /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr593/evs/v2.0/prep/global_ens/chem.20241014/gefs/aeronet_All_20241014_lev15.nc looks good as well

Ho-ChunHuang-NOAA commented 1 month ago

Wait for me to find out why there is a file "6" produced in the DATA.

malloryprow commented 1 month ago

Do we have a good date we can test to make sure all is okay there too? If I remove the INITDATE and DCOMINaeronet, will testing today's run be okay?

malloryprow commented 1 month ago

Waiting!

Ho-ChunHuang-NOAA commented 1 month ago

Find the problem, but it won't impact PR testing already done.

Please go ahead to run today's prep after the pull.

malloryprow commented 1 month ago

jevs_global_ens_chem_grid2obs_prep.sh - Good Data

Ran with INITDATE=20241019 and DCOMINaeronet=/lfs/h1/ops/prod/dcom

Log File: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr593/EVS/dev/drivers/scripts/prep/global_ens/jevs_global_ens_chem_grid2obs_prep.o158974709 COMOUT: /lfs/h2/emc/vpppg/noscrub/mallory.row/verification/EVS_PRs/pr593/evs/v2.0 DATA: /lfs/h2/emc/stmp/mallory.row/evs_test/prod/tmp/jevs_global_ens_chem_grid2obs_prep.158974709.cbqs01

Ho-ChunHuang-NOAA commented 1 month ago

Today's prep is successful.

malloryprow commented 1 month ago

@AndrewBenjamin-NOAA This needs your review (and pending approval) when you get a chance.

malloryprow commented 1 month ago

@Ho-ChunHuang-NOAA Can you do a sync fork before I merge?

Ho-ChunHuang-NOAA commented 1 month ago

done