search

NOAA-EMC / Fit2Obs

0 stars 5 forks source link

Add Jet Support #9

Closed DavidHuber-NOAA closed 1 year ago

DavidHuber-NOAA commented 1 year ago

Adds a subfits script for Jet and build instructions to the makes script for Jet.

This PR also brings in some script changes to match up new variable names in the global workflow and converts scripts to bash from sh and ksh. These latter changes were made by @KateFriedman-NOAA and required to test the build on Jet. If necessary, I can resubmit this PR with just the new build scripts.

Fixes #5

DavidHuber-NOAA commented 1 year ago

This PR is out of date. I will incorporate the CMake changes and rework.

KateFriedman-NOAA commented 1 year ago

@DavidHuber-NOAA The Jet build updates have to get into the Cmake build files now that the Fit2Obs repo was Cmake'd. Looks like your branch is behind Fit2Obs develop (Cmake updates I suspect). Probably best to close this and resubmit with just the Jet Cmake build updates. I have to undo some changes in my branch for the Cmake exec/ush changes after Jack moved things back in develop. Then run another cycle to make sure it's good and then have Jack look at outputs before I submit my own PR.

KateFriedman-NOAA commented 1 year ago

Oops, I dillydallied on submitting my comment. I see this is closed now. Thanks @DavidHuber-NOAA ! :)