Possible bugs in the atm/sfcship YAML?

NOAA-EMC / GDASApp

Global Data Assimilation System Application

GNU Lesser General Public License v2.1

15 stars 31 forks source link

Possible bugs in the atm/sfcship YAML? #1000

Open danholdaway opened 6 months ago

danholdaway commented 6 months ago

When converting YAMLs to JCB I found these potential bugs in the sfcship YAMLs. There are several duplicate keys which means only one can be used (which one may depend on eckit policy). It looks like there should perhaps be a separate bounds/background checks for each variable rather than just one as there is presently. It's a Valid YAML so may cause confusion later.

https://github.com/NOAA-EMC/GDASApp/blob/3ffc340fec25dcd53918194baac98226d01e1179/parm/atm/obs/config/sfcship.yaml.j2#L33

ADCollard commented 6 months ago

@danholdaway Just so you know, this is actually a placeholder. This YAML need to be reviewed and replaced anyway. But I can fix the YAML to at least make it unambiguous.

danholdaway commented 6 months ago

Fair enough, I wondered if that might be the case. You can also wait until JCB replaces it.

danholdaway commented 6 months ago

@ADCollard I also see that in the ATMS N20 use_flag list there is 1s and a 4. Does 4 have a meaning different than 1?