test_gdasapp_fv3jedi_fv3inc fails due to executable name mismatch

RussTreadon-NOAA commented 6 months ago

test_gdasapp_fv3jedi_fv3inc fails with the error

1737: Test command: /opt/slurm/bin/srun "-n6" "/work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/build/bin/gdas_fv3jedi_fv3inc.x" "/work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/build/gdas/test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml"
1737: Test timeout computed to be: 1500
1737: slurmstepd: error: execve(): /work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/build/bin/gdas_fv3jedi_fv3inc.x: No such file or directory

The GDASApp build creates executable fv3jedi_fv3inc.x in build/bin.

In contrast, test/fv3jedi/CMakeLists.txt refers to executable gdas_fv3jedi_fv3inc.x

# Tests
add_test(NAME test_gdasapp_fv3jedi_fv3inc
         COMMAND srun -n6 ${CMAKE_BINARY_DIR}/bin/gdas_fv3jedi_fv3inc.x ${PROJECT_BINARY_DIR}/test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml

Assuming we want to retain the name of the executable in build/bin, we need to change test/fv3jedi/CMakeLists.txt to read

# Tests
add_test(NAME test_gdasapp_fv3jedi_fv3inc
         COMMAND srun -n6 ${CMAKE_BINARY_DIR}/bin/fv3jedi_fv3inc.x ${PROJECT_BINARY_DIR}/test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml

That is, remove gdas_ from the head of the executable filename.

RussTreadon-NOAA commented 6 months ago

As a test, remove gdas_ from the name of the executable in test/fv3jedi/CMakeLists.txt. Remake GDASApp and run test_gdasapp_fv3jedi_fv3inc with the following result

Test project /work2/noaa/da/rtreadon/git/global-workflow/test/sorc/gdas.cd/build
    Start 1737: test_gdasapp_fv3jedi_fv3inc
1/1 Test #1737: test_gdasapp_fv3jedi_fv3inc ......   Passed    5.06 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   5.69 sec

RussTreadon-NOAA commented 6 months ago

Work for this issue will be done in feature/test_gdasapp_fv3jedi_fv3inc

NOAA-EMC / GDASApp

test_gdasapp_fv3jedi_fv3inc fails due to executable name mismatch #1009