Fix inconsistent VIIRS preprocessing test

NOAA-EMC / GDASApp

Global Data Assimilation System Application

GNU Lesser General Public License v2.1

15 stars 31 forks source link

Fix inconsistent VIIRS preprocessing test #1012

Closed CoryMartin-NOAA closed 6 months ago

CoryMartin-NOAA commented 6 months ago

Closes #993

The preqc key was missing from the test YAML and eckit just decided to place some integer in there. This PR should ensure tests pass on all platforms instead of just by chance.

CoryMartin-NOAA commented 6 months ago

@ypwang19 @RussTreadon-NOAA adding this one line causes the test to pass on Hera. Adding this line but making preqc: 1 causes Orion to fail the same way Hera did. So this change should be the correct fix.

CoryMartin-NOAA commented 6 months ago

@RussTreadon-NOAA nope, still passes on Orion with preqc: 2. I think it was just some sort of coincidence that it passed before. It's not clear to me why it didn't fail when looking for that value and not finding it, but instead just putting in an integer.