search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
15 stars 31 forks source link

Add MODIS Terra/Aqua satwinds assimilation to end-to-end GDASApp validation #1030

Closed BrettHoover-NOAA closed 5 months ago

BrettHoover-NOAA commented 6 months ago

Adding satwinds from the Moderate Resolution Imaging Spectroradiometer (MODIS) from Terra/Aqua to GDASApp end-to-end testing

new files include: parm/atm/obs/config/satwind_modis_terra.yaml.j2: QC filter YAML for MODIS Terra satwinds (jinja2 standard) parm/atm/obs/config/satwind_modis_aqua.yaml.j2: QC filter YAML for MODIS Aqua satwinds (jinja2 standard) parm/ioda/bufr2ioda/bufr2ioda_satwind_amv_modis.json: JSON containing data format, sensor, and satellite information for MODIS Terra/Aqua satwinds ush/ioda/bufr2ioda/bufr2ioda_satwind_amv_modis.py: bufr2ioda code for extracting MODIS Terra/Aqua satwinds from BUFR

See #1029 for end-to-end testing results. Acceptance and ob-errors agree well with some expected deviation. Thinning is currently turned off in both GSI and JEDI for these tests.

Note: We are still using qualityInformationWithoutForecast as the variable-name for QI in the IODA converter. This variable-name is currently not registered in the IODA ObsSpace.yaml, but there is an ongoing discussion with JCSDA to have it added, issue is here: https://github.com/JCSDA-internal/ioda/issues/1233

emilyhcliu commented 6 months ago

@BrettHoover-NOAA I will check out the branch and run tests! The end-to-end results you reported look good!

BrettHoover-NOAA commented 5 months ago

@emilyhcliu can this PR get reviewed and merged? I am going to go back and make a change to all of the satwind code to change the variable-name for qualityInformationWithoutForecast to comply with ioda ObsSpace.yaml standards, but this should get in first.