search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Variance Partition estimates of Stddev #1037

Closed andytangborn closed 3 months ago

andytangborn commented 3 months ago

This PR creates code and a yaml (adapted from SOCA) that computes time dependent background error standard deviations using neighboring grid points. These are created "on the fly", eliminating a need for staticB stddev files that need to be switched in or out each season.

andytangborn commented 3 months ago

Not sure what this means.

andytangborn dismissed guillaumevernieres’s stale review via 837de5a now

CoryMartin-NOAA commented 3 months ago

it means his previous review is no longer applicable because you updated the branch

andytangborn commented 3 months ago

I just noticed these lines in chem_diagb.h. These should be removed I think?

 // Get the std dev to add to sst
  double sstBkgErrMin(0.0);
  fullConfig.get("min sst", sstBkgErrMin);

  // Get the max std dev for ssh
  double sshMax(0.0);
  fullConfig.get("max ssh", sshMax);
CoryMartin-NOAA commented 3 months ago

@andytangborn yes you don't need ssh or sst