NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

remove seviri from gdas_prototype_3d yaml #1043

Closed RussTreadon-NOAA closed 3 months ago

RussTreadon-NOAA commented 3 months ago

This PR removes

-{% include 'atm/obs/config/seviri_m08.yaml.j2' %}
-{% include 'atm/obs/config/seviri_m11.yaml.j2' %}

from parm/atm/obs/lists/gdas_prototype_3d.yaml.j2. Doing so allows GDASApp ATM variational cycling to run for cases from 20221005 12Z to present.

Fixes #1008

RussTreadon-NOAA commented 3 months ago

@CoryMartin-NOAA , @guillaumevernieres , and @danholdaway: pending no objections from you I would like to merge this PR into develop before 4 pm today. This PR should interfere with other work but I've been away for two weeks so I'm not up to speed on where things stand.

danholdaway commented 3 months ago

These files are changes with incoming jcb but I will update them in the same way. By the way jcb offers a way to deal with missing data that we could utilize while we wait for a JEDI that does not fail with missing observations.

RussTreadon-NOAA commented 3 months ago

Thank you @danholdaway for your reply. Sorry that this PR adds a wrinkle to your JCB work. Missing data remains the Achilles heel of real-time cycling. Good to hear that JCB offers a way to address this problem until JEDI itself can handle missing observations.

I'll go ahead and merge this PR into develop.

CoryMartin-NOAA commented 3 months ago

while we wait for a JEDI that does not fail with missing observations.

In this case, I don't think it's a JEDI problem, but our converters' lack of fault tolerance. As far as I know, IODA can handle missing files now.