search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Refactoring prepocnobs task #1049

Closed AndrewEichmann-NOAA closed 3 months ago

AndrewEichmann-NOAA commented 3 months ago

Makes prepocnobs a wxflow Task. Also tweaks the BUFR to IODA converter for argo floats, necessary for testing purposes.

Fixes https://github.com/NOAA-EMC/GDASApp/issues/1047

emcbot commented 3 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Wed Apr 17 00:35:42 UTC 2024 on hfe06
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 00:36:27 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest
emcbot commented 3 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Tue Apr 16 19:45:36 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Apr 16 19:46:25 CDT 2024
Tests: 
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest
emcbot commented 3 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Wed Apr 17 00:35:42 UTC 2024 on hfe06
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Apr 17 00:36:27 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS Build: Completed at Wed Apr 17 01:27:04 UTC 2024

Tests: Failed Tests: Failed at Wed Apr 17 01:42:14 UTC 2024 Tests: 91% tests passed, 5 tests failed out of 54 1763 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed) 1776 - test_gdasapp_atm_jjob_var_run (Failed) 1777 - test_gdasapp_atm_jjob_var_inc (Failed) 1778 - test_gdasapp_atm_jjob_var_final (Failed) Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest

emcbot commented 3 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Tue Apr 16 19:45:36 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Apr 16 19:46:25 CDT 2024
Tests: 
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS Build: Completed at Tue Apr 16 20:40:48 CDT 2024

Tests: Failed Tests: Failed at Tue Apr 16 21:03:15 CDT 2024 Tests: 93% tests passed, 4 tests failed out of 54 1777 - test_gdasapp_atm_jjob_var_run (Failed) 1778 - test_gdasapp_atm_jjob_var_inc (Failed) 1779 - test_gdasapp_atm_jjob_var_final (Failed) Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1049/global-workflow/sorc/gdas.cd/build/log.ctest

AndrewEichmann-NOAA commented 3 months ago

Nice and clean! Thanks @AndrewEichmann-NOAA Looks like we need to do a short test run with all/most of the obs types before we merge this.

@guillaumevernieres What's the latest in experiment configs to do this?

AndrewEichmann-NOAA commented 3 months ago

PYTHONPATH fix got merged: https://github.com/NOAA-EMC/global-workflow/pull/2504