NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Marine obs naming convention is not correct #1068

Closed guillaumevernieres closed 2 months ago

guillaumevernieres commented 2 months ago

I just noticed that the cyc variable is not formatted properly. The problem is probably here: https://github.com/NOAA-EMC/GDASApp/blob/3bb46b61e710a77e85916d9b20388df1e1f390f3/ush/soca/prep_ocean_obs.py#L71 add .zfill(2) or something ...

This is what we get for the 0z cycle, gdas.t0z.* instead of gdas.t00z.*:

./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.icec_amsr2_north.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.adt_rads_all.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.icec_amsr2_south.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_abi_g17_l3c.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_abi_g16_l3c.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_viirs_npp_l3u.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_ahi_h08_l3c.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_avhrr_ma_l3u.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_avhrr_mb_l3u.2021070200.nc4
./cp1.e/COMROOT/cp1.e/gdas.20210702/00/obs/gdas.t0z.sst_viirs_n20_l3u.2021070200.nc4

I suspect the same for 6z.