search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Addition of a switch for the cycling type #1072

Closed guillaumevernieres closed 2 months ago

guillaumevernieres commented 2 months ago

Draft because I still need to test this while cycling.

guillaumevernieres commented 2 months ago

FYI @JessicaMeixner-NOAA , that "should" fix the current issue, but I have yet to test within a proper cycling test ...

guillaumevernieres commented 2 months ago

As @JessicaMeixner-NOAA wrote above @apchoiCMD , it's still broken ... Working on a fix. I'm re-requesting reviews so we don't see green checks on the review side, if anything just block the pr.

apchoiCMD commented 2 months ago

As @JessicaMeixner-NOAA wrote above @apchoiCMD , it's still broken ... Working on a fix. I'm re-requesting reviews so we don't see green checks on the review side, if anything just block the pr.

Got it, I just assumed that you asked me to review again- @guillaumevernieres

emcbot commented 2 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Wed Apr 24 17:35:59 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Apr 24 18:25:55 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Apr 24 18:55:31 CDT 2024
Tests: 100% tests passed, 0 tests failed out of 45
JessicaMeixner-NOAA commented 2 months ago

@guillaumevernieres I see regtests are running here. Has the additional bug-fix been added? Should I retest on my side?

guillaumevernieres commented 2 months ago

@guillaumevernieres I see regtests are running here. Has the additional bug-fix been added? Should I retest on my side?

Not yet @JessicaMeixner-NOAA . ~We try to emulate the cycling in our ctest, but it's not perfect. The ci should have failed. I'll try to have the fix today.~ It didn't fail because we're not testing the "iau" cycling case.