search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Add modulefile for Dogwood/Cactus #1073

Closed CoryMartin-NOAA closed 2 months ago

CoryMartin-NOAA commented 2 months ago

While we are technically not supposed to build our own CRTM or FMS, we are asking for forgiveness and forging ahead. This PR should allow GDASApp to compile on WCOSS2 (Dogwood and Cactus) after a minor issue is resolved. That issue being a compile issue in IODA that Ron is already aware of and has a fix that works (https://github.com/JCSDA-internal/ioda/compare/develop...bugfix/read_script_convert_fix).

CoryMartin-NOAA commented 2 months ago

I'll mark this as ready for review once I am able to update the submodules when the IODA pull request is merged in

RussTreadon-NOAA commented 2 months ago

Shall we try to run ctest -R test_gdasapp on WCOSS2 or are additional changes needed? I think we need PBS equivalents of SLURM stuff.

CoryMartin-NOAA commented 2 months ago

@RussTreadon-NOAA we can try, but as you note I expect it won't be trivial. I would suggest we tackle that in a subsequent PR.

RussTreadon-NOAA commented 2 months ago

Simply loaded wcoss2.intel module and executed ctest -R test_gdasapp from build/ with the following result

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build
      Start 1337: test_gdasapp_util_coding_norms
 1/22 Test #1337: test_gdasapp_util_coding_norms .............   Passed    3.03 sec
      Start 1338: test_gdasapp_util_ioda_example
 2/22 Test #1338: test_gdasapp_util_ioda_example .............***Failed    0.27 sec
      Start 1339: test_gdasapp_util_prepdata
 3/22 Test #1339: test_gdasapp_util_prepdata .................   Passed    0.48 sec
      Start 1340: test_gdasapp_util_rads2ioda
 4/22 Test #1340: test_gdasapp_util_rads2ioda ................   Passed    0.11 sec
      Start 1341: test_gdasapp_util_ghrsst2ioda
 5/22 Test #1341: test_gdasapp_util_ghrsst2ioda ..............   Passed    0.10 sec
      Start 1342: test_gdasapp_util_smap2ioda
 6/22 Test #1342: test_gdasapp_util_smap2ioda ................   Passed    0.10 sec
      Start 1343: test_gdasapp_util_smos2ioda
 7/22 Test #1343: test_gdasapp_util_smos2ioda ................   Passed    0.10 sec
      Start 1344: test_gdasapp_util_viirsaod2ioda
 8/22 Test #1344: test_gdasapp_util_viirsaod2ioda ............   Passed    0.10 sec
      Start 1345: test_gdasapp_util_icecamsr2ioda
 9/22 Test #1345: test_gdasapp_util_icecamsr2ioda ............   Passed    0.10 sec
      Start 1618: test_gdasapp_check_python_norms
10/22 Test #1618: test_gdasapp_check_python_norms ............   Passed    3.72 sec
      Start 1619: test_gdasapp_check_yaml_keys
11/22 Test #1619: test_gdasapp_check_yaml_keys ...............   Passed    0.15 sec
      Start 1620: test_gdasapp_jedi_increment_to_fv3
12/22 Test #1620: test_gdasapp_jedi_increment_to_fv3 .........   Passed    0.46 sec
      Start 1621: test_gdasapp_fv3jedi_fv3inc
Could not find executable srun
Looked in the following places:
srun
srun
Release/srun
Release/srun
Debug/srun
Debug/srun
MinSizeRel/srun
MinSizeRel/srun
RelWithDebInfo/srun
RelWithDebInfo/srun
Deployment/srun
Deployment/srun
Development/srun
Development/srun
Unable to find executable: srun
13/22 Test #1621: test_gdasapp_fv3jedi_fv3inc ................***Not Run   0.00 sec
      Start 1622: test_gdasapp_soca_nsst_increment_to_mom6
14/22 Test #1622: test_gdasapp_soca_nsst_increment_to_mom6 ...***Failed    1.10 sec
      Start 1623: test_gdasapp_snow_create_ens
15/22 Test #1623: test_gdasapp_snow_create_ens ...............   Passed    0.54 sec
      Start 1624: test_gdasapp_snow_imsproc
16/22 Test #1624: test_gdasapp_snow_imsproc ..................***Failed    0.11 sec
      Start 1625: test_gdasapp_snow_apply_jediincr
17/22 Test #1625: test_gdasapp_snow_apply_jediincr ...........***Failed    0.12 sec
      Start 1626: test_gdasapp_snow_letkfoi_snowda
18/22 Test #1626: test_gdasapp_snow_letkfoi_snowda ...........***Failed    0.59 sec
      Start 1627: test_gdasapp_convert_bufr_adpsfc_snow
19/22 Test #1627: test_gdasapp_convert_bufr_adpsfc_snow ......***Failed    0.03 sec
      Start 1628: test_gdasapp_convert_bufr_adpsfc
Could not find executable /lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
Looked in the following places:
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Release/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Release/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Debug/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Debug/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/MinSizeRel/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/MinSizeRel/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/RelWithDebInfo/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/RelWithDebInfo/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Deployment/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Deployment/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Development/bufr2ioda.x
/lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Development/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Release/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Release/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Debug/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Debug/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/MinSizeRel/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/MinSizeRel/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/RelWithDebInfo/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/RelWithDebInfo/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Deployment/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Deployment/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Development/bufr2ioda.x
lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/Development/bufr2ioda.x
Unable to find executable: /lfs/h2/emc/da/noscrub/russ.treadon/git/GDASApp/wcoss2/build/bin/bufr2ioda.x
20/22 Test #1628: test_gdasapp_convert_bufr_adpsfc ...........***Not Run   0.00 sec
      Start 1629: test_gdasapp_convert_gsi_satbias
21/22 Test #1629: test_gdasapp_convert_gsi_satbias ...........   Passed    2.02 sec
      Start 1630: test_gdasapp_aero_gen_3dvar_yaml
22/22 Test #1630: test_gdasapp_aero_gen_3dvar_yaml ...........***Failed    0.07 sec

59% tests passed, 9 tests failed out of 22

Label Time Summary:
gdas-utils    =   4.38 sec*proc (9 tests)
script        =   4.38 sec*proc (9 tests)

Total Test time (real) =  14.22 sec

The following tests FAILED:
        1338 - test_gdasapp_util_ioda_example (Failed)
        1621 - test_gdasapp_fv3jedi_fv3inc (Not Run)
        1622 - test_gdasapp_soca_nsst_increment_to_mom6 (Failed)
        1624 - test_gdasapp_snow_imsproc (Failed)
        1625 - test_gdasapp_snow_apply_jediincr (Failed)
        1626 - test_gdasapp_snow_letkfoi_snowda (Failed)
        1627 - test_gdasapp_convert_bufr_adpsfc_snow (Failed)
        1628 - test_gdasapp_convert_bufr_adpsfc (Not Run)
        1630 - test_gdasapp_aero_gen_3dvar_yaml (Failed)
Errors while running CTest

Errors are not surprising.

RussTreadon-NOAA commented 2 months ago

Agreed. Let's merge this PR into develop. Being able to compile GDASApp on WCOSS2 is a great way to end the work week!

CoryMartin-NOAA commented 2 months ago

@RussTreadon-NOAA yes, has been a long time coming!

emcbot commented 2 months ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Fri Apr 26 17:56:06 UTC 2024 on hfe02
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr 26 18:46:13 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Apr 26 19:04:47 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 45