search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Feature/rtofs in situ #1138

Closed givelberg closed 3 weeks ago

givelberg commented 1 month ago

Created 2 converters with corresponding tests, for temperature and salinity. 2 different files are created. For temperature the file includes tmp, tmp_err, lon, lat, depth and metadata sal_typ and flg Similarly, for salinity..

emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Sun Jun  9 20:50:24 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sun Jun  9 21:37:04 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Sun Jun  9 22:00:29 CDT 2024
Tests: 96% tests passed, 2 tests failed out of 48
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/gdas.cd/build/log.ctest
emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Mon Jun 10 02:01:56 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jun 10 02:48:27 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jun 10 03:15:10 UTC 2024
Tests: 96% tests passed, 2 tests failed out of 48
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/gdas.cd/build/log.ctest
guillaumevernieres commented 3 weeks ago

Looks like you forgot to add the yaml files for the tests @givelberg :

 6/48 Test #1493: test_gdasapp_util_rtofstmp ............................Subprocess aborted***Exception:   0.82 sec                                                                                                        
Exception: Cannot open ../testinput/gdas_rtofstmp.yaml  (No such file or directory)                                                                                                                                        
terminate called after throwing an instance of 'eckit::CantOpenFile'                                                                                                                                                       
  what():  Cannot open ../testinput/gdas_rtofstmp.yaml  (No such file or directory)                                                                                                                                        

      Start 1494: test_gdasapp_util_rtofssal                                                                                                                                                                               
 7/48 Test #1494: test_gdasapp_util_rtofssal ............................Subprocess aborted***Exception:   0.60 sec                                                                                                        
Exception: Cannot open ../testinput/gdas_rtofssal.yaml  (No such file or directory)                                                                                                                                        
terminate called after throwing an instance of 'eckit::CantOpenFile'                                                                                                                                                       
  what():  Cannot open ../testinput/gdas_rtofssal.yaml  (No such file or directory)
emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Mon Jun 10 09:31:04 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Mon Jun 10 09:49:45 CDT 2024
Build: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/log.build
emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Mon Jun 10 14:30:53 UTC 2024 on hfe05
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Mon Jun 10 14:50:20 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1138/global-workflow/sorc/log.build
emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: orion

Start: Mon Jun 10 12:15:51 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jun 10 13:00:43 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jun 10 13:27:26 CDT 2024
Tests: 100% tests passed, 0 tests failed out of 48
emcbot commented 3 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Mon Jun 10 17:15:41 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jun 10 18:04:46 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jun 10 18:31:28 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48
RussTreadon-NOAA commented 3 weeks ago

This PR changed the hash for the following repos in sorc/: fv3, gsibec, gsw, land-imsproc, land-jediincr. The modified hashes in this PR are newer than what was previously in GDASApp sorc/ except for gsibec.

This PR changed gsibec to `gsibec @ e6e1944. This commit is dated June 26, 2203.

Before this PR was merged into develop, we were using gsibec @ c8ac58d. This commit is dated March 8, 2024. This gsibec hash is tags/1.2.1.

g-w C96C48_ufs_hybatmDA CI using the current head of GDASApp (7f4c2fc) failed when running the gfs and gdas atmanlvar. Both job aborted with the error message

 0: Exception: gsi static covariance does not exist in saber::SaberCentralBlockFactory
 0: Exception: oops::Variational<FV3JEDI, UFO and IODA observations> terminating...
 0: Exception: level: 0
 0: gsi static covariance does not exist in saber::SaberCentralBlockFactory
 0: OOPS Ending   2024-06-11 16:39:22 (UTC+0000)

This reason for this failure is that the gsibec hash GDASApp currently points at is out of date with other repository snapshots in sorc/. As a test gsibec was updated to gsibec tags/1.2.1 and GDASApp rebuilt. Reruns of the g-w CI gfs and gdas atmanlvar jobs were successful.

We need to revert sorc/gsibec back to gsibec tags/1.2.1 (hash c8ac58d)

guillaumevernieres commented 3 weeks ago

Ouch, sorry about this @RussTreadon-NOAA . Not quite sure how I missed this but I did ...