NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 28 forks source link

Point the CI to the dev/gdasapp global workflow branch #1169

Closed guillaumevernieres closed 2 weeks ago

guillaumevernieres commented 3 weeks ago

I have not touched the "stable" script, this is just to change the CI to point to dev/gdsaapp.

I'll work next on fixing the gw_ci test, for some reason the hpc account is not updated properly. But in the meantime, the plan is to do bushiness as usual with a different branch.

guillaumevernieres commented 3 weeks ago

Approve

Thanks @RussTreadon-NOAA . I should have done that before submitting this PR: I'm going to update the README as well ...

emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Wed Jun 12 17:56:21 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jun 12 18:49:43 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jun 12 19:16:33 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48
RussTreadon-NOAA commented 2 weeks ago

I manually ran gw_driver.sh as role.jedipara on Hera. It ran to completion for this PR, #1169, and finished with the following command line output in the Hera PuTTY session

+ /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci/run_gw_ci.sh -d /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/global-workflow -o /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/output_e0c4c8e
Begin link_workflow.sh at Wed Jun 12 18:49:43 UTC 2024
End link_workflow.sh at 18:49:43 with error code 0 (time elapsed: 00:00:00)
+ ci_status=0
+ gh pr comment 1169 --body-file /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169/output_e0c4c8e
https://github.com/NOAA-EMC/GDASApp/pull/1169#issuecomment-2163735457
+ '[' 0 -eq 0 ']'
+ gh pr edit 1169 --remove-label hera-GW-RT-Running --add-label hera-GW-RT-Passed
https://github.com/NOAA-EMC/GDASApp/pull/1169
+ find /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1169 -maxdepth 1 -mtime +3 -exec rm -rf '{}' ';'

Looks like CI from role.jedipara works. I have not yet enabled a cron to run CI in the background. The above test was executed from the command line.

CoryMartin-NOAA commented 2 weeks ago

@RussTreadon-NOAA perhaps tomorrow morning we coordinate turning it on for jedipara and off for my account, and we see how it goes tomorrow and Friday?

guillaumevernieres commented 2 weeks ago

@CoryMartin-NOAA , @RussTreadon-NOAA , @danholdaway I added some logic to check for a companion pr in the global-workflow and clone that if it does exist. I only tested a small chunk of the added script, running the ci again now.

emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Wed Jun 12 22:10:40 UTC 2024 on hfe12
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jun 12 22:52:06 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Jun 12 23:17:10 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 48
guillaumevernieres commented 2 weeks ago

Note for tomorrow: check that the g-w and gdasapp branches that were checked out is the correct ones.

emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Thu Jun 13 16:21:57 UTC 2024 on hfe01
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jun 13 16:22:33 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest
emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Thu Jun 13 16:21:57 UTC 2024 on hfe01
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Jun 13 16:22:33 UTC 2024
Tests: 
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest

Build: SUCCESS Build: Completed at Thu Jun 13 17:07:48 UTC 2024

Tests: SUCCESS Tests: Completed at Thu Jun 13 17:32:34 UTC 2024 Tests: 100% tests passed, 0 tests failed out of 48

emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Fri Jun 14 19:15:44 UTC 2024 on hfe08
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Jun 14 19:20:48 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/log.build
CoryMartin-NOAA commented 2 weeks ago

@guillaumevernieres @RussTreadon-NOAA FYI I'm going to be on leave until Thursday so I won't be able to help debug the CI running in my user account. I'm going to revert it to develop again, just so existing capabilities are not broken. Debugging can happen on the role account if necessary.

RussTreadon-NOAA commented 2 weeks ago

Hera test Did the following as role.jedipara

  1. clone feature/devgdasapp
  2. cp ci/gw_driver.sh /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci
  3. create forked g-w branch named feature/ci to match the same branch name, feature/ci, referenced by GDASApp PR #1173
  4. add label hera-GW-RT to GDASApp PR #1173
  5. execute /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/repo/ci/gw_driver.sh -t hera
  6. 48 our of 48 test_gdasapp pass
  7. PR #1173 label updated to hera-GW-RT-Passed
emcbot commented 2 weeks ago

Automated Global-Workflow GDASApp Testing Results: Machine: hera

Start: Fri Jun 14 19:15:44 UTC 2024 on hfe08
---------------------------------------------------
Build:                                  *FAILED*
Build: Failed at Fri Jun 14 19:20:48 UTC 2024
Build: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/log.build

Build: SUCCESS Build: Completed at Fri Jun 14 20:06:48 UTC 2024

Tests: Failed Tests: Failed at Fri Jun 14 21:30:33 UTC 2024 Tests: 98% tests passed, 1 tests failed out of 48 Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1169/global-workflow/sorc/gdas.cd/build/log.ctest

RussTreadon-NOAA commented 2 weeks ago

Changes in feature/devgdasapp have been merged into RussTreadon-NOAA:feature/ci. See PR #1173

guillaumevernieres commented 2 weeks ago

Changes included in #1173