Open RussTreadon-NOAA opened 2 weeks ago
Work for this issue will be done in feature/update_names
ufo PR #3476 changes the name used for several model variables as shown in the ufo at e5e623b commit log below
commit e5e623bfde16c034f6ded4bf5c32e10db7f22f3a (HEAD, origin/develop)
Author: Anna Shlyaeva <annash@ucar.edu>
Date: Tue Oct 8 11:03:57 2024 -0600
Model Variable Naming Sprint: Part 5 (#3476)
* surface_geometric_height -> height_above_mean_sea_level_at_surface
* surface_altitude -> height_above_mean_sea_level_at_surface
* geometric_height -> height_above_mean_sea_level
* surface_geopotential_height -> geopotential_height_at_surface
* surface_pressure -> air_pressure_at_surface
* WIP height -> height_above_mean_sea_level
* Rename model height in yamls
The surface_pressure -> air_pressure_at_surface
change causes test_gdasapp_fv3jedi_fv3inc
to fail with
Assertion failed: FieldMetadata::FieldsMetadata: Trying to override surface_pressure but this long name does not exist in the metadata. in FieldsMetadata, line 52 of /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/stable/20241008/global-workflow/sorc/gdas.cd/bundle/fv3-jedi/src/fv3jedi/FieldMetadata/FieldsMetadata.cc
This test also references surface_geopotential_height
. With the updated ufo hash surface_geopotential_height -> geopotential_height_at_surface
The fix for test_gdasapp_jedi_increment_to_fv3
is simple. surface_pressure
in test/fv3jedi/testoutput/gdasapp_fv3jedi_fv3inc.ref
needs to be replaced with air_pressure_at_surface
. After this change is made
Hera(hfe07):/scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/stable/20241008/global-workflow/sorc/gdas.cd/build$ ctest -R test_gdasapp_jedi_increment_to_fv3
Test project /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/stable/20241008/global-workflow/sorc/gdas.cd/build
Start 1945: test_gdasapp_jedi_increment_to_fv3
1/1 Test #1945: test_gdasapp_jedi_increment_to_fv3 ... Passed 0.92 sec
100% tests passed, 0 tests failed out of 1
Total Test time (real) = 1.41 sec
@danholdaway , when do we anticipate all the PRs for the Model variable naming code sprint to be merged into develop
for various jcsda repos?
Correction
My previous comments regarding what's needed to get test_gdasapp_fv3jedi_fv3inc
to pass are incorrect. I ran ush/submodules/update_develop.sh
again. Now the following changes are needed
parm/io/fv3jedi_fieldmetadata_history.yaml
test/fv3jedi/testinput/gdasapp_fv3jedi_fv3inc.yaml
test/fv3jedi/testoutput/gdasapp_fv3jedi_fv3inc.ref
The following variables are renamed
surface_pressure
--> air_pressure_at_surface
surface_geopotential_height
--> geopotential_height_at_surface
sfc_geopotential_height_times_grav
--> geopotential_height_times_gravity_at_surface
The JEDI Model Variable Naming Sprint requires updates to GDASApp yamls. This issue is opened to document these updates.