search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
15 stars 31 forks source link

Changes prepoceanobs to using newly refactored BUFR converters #1352

Closed AndrewEichmann-NOAA closed 1 week ago

AndrewEichmann-NOAA commented 3 weeks ago

Just like the title. This mainly changes the converters used to the new ones that use yaml files, the templates for which are included, along with a little script that does most of the work of converting the earlier JSON templates to yaml. Also removes from ocean.py some methods for plotting, but can't go into global-workflow because of lack of the necessary python modules in that environment.

RussTreadon-NOAA commented 3 weeks ago

Install this GDASApp PR and g-w PR #2992 on Hera. Run test_gdasapp ctests. The following tests fail in both installations

        1953 - test_gdasapp_bufr2ioda_insitu_profile_argo (Failed)
        1954 - test_gdasapp_bufr2ioda_insitu_profile_bathy (Failed)
        1955 - test_gdasapp_bufr2ioda_insitu_profile_glider (Failed)
        1956 - test_gdasapp_bufr2ioda_insitu_profile_tesac (Failed)
        1957 - test_gdasapp_bufr2ioda_insitu_profile_tropical (Failed)
        1958 - test_gdasapp_bufr2ioda_insitu_profile_xbtctd (Failed)
        1959 - test_gdasapp_bufr2ioda_insitu_surface_drifter (Failed)
        1960 - test_gdasapp_bufr2ioda_insitu_surface_trkob (Failed)

Each of these jobs fail with the error message

    from b2iconverter.bufr2ioda_converter import Bufr2ioda_Converter
  File "/scratch1/NCEPDEV/da/Russ.Treadon/git/GDASApp/pr1352/ush/ioda/bufr2ioda/marine/b2i/b2iconverter/bufr2ioda_converter.py", line 7, in <module>
    from pyiodaconv import bufr
ModuleNotFoundError: No module named 'pyiodaconv'

Do we have a fix for these failures in the development pipeline?

guillaumevernieres commented 3 weeks ago

Thanks for pointing this out @RussTreadon-NOAA . I created an issue off of your comment above.

emcbot commented 1 week ago

Automated GW GDASApp Testing Results: Machine: hera

Start: Tue Nov 12 20:09:02 UTC 2024 on hfe06
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Nov 12 20:56:57 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Nov 12 22:57:31 UTC 2024
Tests: 80% tests passed, 13 tests failed out of 64
    1955 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marinebmat_202103241800 (Failed)
    1956 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlinit_202103241800 (Failed)
    1957 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlvar_202103241800 (Failed)
    1958 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlchkpt_202103241800 (Failed)
    1959 - test_gdasapp_WCDA-3DVAR-C48mx500_gdas_marineanlfinal_202103241800 (Failed)
    1968 - test_gdasapp_WCDA-hyb-C48mx500_gdas_marineanlletkf_202103241800 (Failed)
    1972 - test_gdasapp_atm_jjob_var_init (Failed)
    1973 - test_gdasapp_atm_jjob_var_run (Failed)
    1974 - test_gdasapp_atm_jjob_var_inc (Failed)
    1975 - test_gdasapp_atm_jjob_var_final (Failed)
    1980 - test_gdasapp_atm_jjob_ens_sol (Failed)
    1981 - test_gdasapp_atm_jjob_ens_inc (Failed)
    1982 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1352/global-workflow/sorc/gdas.cd/build/log.ctest