search

NOAA-EMC / GDASApp

Global Data Assimilation System Application
GNU Lesser General Public License v2.1
14 stars 30 forks source link

Marine DA is broken #988

Closed guillaumevernieres closed 5 months ago

guillaumevernieres commented 5 months ago 
          Automated Global-Workflow GDASApp Testing Results:

Machine: orion

Start: Tue Mar 19 16:21:07 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Mar 19 17:14:30 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Mar 19 17:37:25 CDT 2024
Tests: 83% tests passed, 9 tests failed out of 54
    1752 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP (Failed)
    1753 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
    1754 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
    1757 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
    1758 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
    1759 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
    1760 - test_gdasapp_soca_socahybridweights (Failed)
    1761 - test_gdasapp_soca_incr_handler (Failed)
    1762 - test_gdasapp_soca_ens_handler (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/981/global-workflow/sorc/gdas.cd/build/log.ctest

Originally posted by @emcbot in https://github.com/NOAA-EMC/GDASApp/issues/981#issuecomment-2008279316

Reported by @RussTreadon-NOAA :

Traceback (most recent call last):
  File "/work2/noaa/da/rtreadon/git/global-workflow/pr928/sorc/gdas.cd/scripts/exgdas_global_marine_analysis_prep.py", line 309, in <module>
    ufsda.yamltools.save_check(varconfig.as_dict(), target=var_yaml, app='var')
TypeError: 'dict' object is not callable

Something is wrong in ufsda.yamltools.save_check, this script remove obs spaces that point to non-existent file.

AndrewEichmann-NOAA commented 5 months ago

@guillaumevernieres is this the gdas/gfs issue that @JessicaMeixner-NOAA brought up?

guillaumevernieres commented 5 months ago

@guillaumevernieres is this the gdas/gfs issue that @JessicaMeixner-NOAA brought up?

No. It's failing during the clean-up of the var.yaml. I'm looking into it today.

RussTreadon-NOAA commented 5 months ago

The change to scripts/exgdas_global_marine_analysis_prep.py in PR #989 does indeed fix g-w based marine DA ctests. Nice job @guillaumevernieres!