NOAA-EMC / GLDAS

0 stars 4 forks source link

Fix build on Orion #20

Closed KateFriedman-NOAA closed 3 years ago

KateFriedman-NOAA commented 3 years ago

The gdas2gldas and gldas2gdas Orion modulefiles have the wrong netcdf hpc-stack module and don't build. The netcdfp/4.7.4 should be netcdf/4.7.4 in those two modulefiles for Orion (remove the "p"). No issues building gldas_gfsv16_release.v1.14.0 on Hera or WCOSS-Dell.

Changed two modulefiles on Orion and the build completed without error. Here are the two diffs:

Orion-login-1[174] /work/noaa/global/kfriedma/git/feature-hpc-stack/sorc/gldas.fd$ git branch
* (detached from gldas_gfsv16_release.v1.14.0)
  master
Orion-login-1[175] /work/noaa/global/kfriedma/git/feature-hpc-stack/sorc/gldas.fd$ git status
# HEAD detached at gldas_gfsv16_release.v1.14.0
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       modified:   modulefiles/gdas2gldas.orion
#       modified:   modulefiles/gldas2gdas.orion
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#       exec/
#       sorc/logs/
no changes added to commit (use "git add" and/or "git commit -a")
Orion-login-1[176] /work/noaa/global/kfriedma/git/feature-hpc-stack/sorc/gldas.fd$ git diff
diff --git a/modulefiles/gdas2gldas.orion b/modulefiles/gdas2gldas.orion
index f37ce11..67e440b 100644
--- a/modulefiles/gdas2gldas.orion
+++ b/modulefiles/gdas2gldas.orion
@@ -12,7 +12,7 @@ module load nemsio/2.5.2
 module load bacio/2.4.1
 module load sp/2.3.3

-module load netcdfp/4.7.4
+module load netcdf/4.7.4
 module load esmf/8_1_0_beta_snapshot_27

 export FCOMP=mpiifort
diff --git a/modulefiles/gldas2gdas.orion b/modulefiles/gldas2gdas.orion
index f37ce11..67e440b 100644
--- a/modulefiles/gldas2gdas.orion
+++ b/modulefiles/gldas2gdas.orion
@@ -12,7 +12,7 @@ module load nemsio/2.5.2
 module load bacio/2.4.1
 module load sp/2.3.3

-module load netcdfp/4.7.4
+module load netcdf/4.7.4
 module load esmf/8_1_0_beta_snapshot_27

 export FCOMP=mpiifort
KateFriedman-NOAA commented 3 years ago

@HelinWei-NOAA Can this fix be made? Thanks!

HelinWei-NOAA commented 3 years ago

Done. The new tag was created. Sorry for the delay.

KateFriedman-NOAA commented 3 years ago

Great, thanks for making the fix and new tag! The new tag builds out of the box on Orion now. Closing issue :)