search

NOAA-EMC / GSI-Monitor

GSI Monitoring Tools
1 stars 10 forks source link

Small cleanup items for RadMon and OznMon #83

Closed EdwardSafford-NOAA closed 1 year ago

EdwardSafford-NOAA commented 1 year ago

This PR contains some small cleanup to the RadMon and OznMon. These are changes I'd made to my local copy some time ago, then got distracted and failed to get into develop. These are both quality of life items for me (@EdwardSafford-NOAA ) and do not affect developers or global-workflow. All changes have been tested over the past week and are correctly handling the operational gfs/gdas data and producing the expected plots and warning messages.

The change to OznMon_Plt.sh corrects the location of the alternate location for gdas_oznmon_satype.txt. The authoritative satype file is located at Ozone_Monitor/nwprod/gdas/fix/gdas_oznmon_satype.txt. However, it sometimes contains sources that are anticipated but not yet available, and if used, would produce erroneous warning messages. A copy of the same file located at ${OZN_TANKDIR_STATS}/info/gdas_oznmon_satype.txt is to take precedence. This change corrects the location of the infodirectory.

The changes to radmon_copy.sh and validate.sh update those files to correctly handle the time series data in a tar file. Tar files were introduced to the RadMon some time ago in an effort to reduce the number of output data files, which is a real issue on hera. These two scripts were not fully updated when that change took place. I'm the only one I'm aware of who uses radmon_copy.sh. It simply copies radmon data from a source (typically operational gdas data) to my local $TANKDIR. The files are to support both non-tarred and tarred data, which they do with these changes.

Completes #82

DavidHuber-NOAA commented 1 year ago

@EdwardSafford-NOAA If you would like, I'm happy to do a review of this.

EdwardSafford-NOAA commented 1 year ago

@DavidHuber-NOAA That would be great, thanks.