enhance safeguards in getsigensmeanp_smooth and recentersigp

NOAA-EMC / GSI-utils

GSI related utilities

3 stars 20 forks source link

enhance safeguards in getsigensmeanp_smooth and recentersigp #41

Closed RussTreadon-NOAA closed 5 months ago

RussTreadon-NOAA commented 5 months ago

CI testing of g-w PR #2592 identified sections of unsafe coding in getsigensmeanp_smooth_ncep.f90 and recentersigp.f90. This PR adds safeguards these source code files which

initialize variables before being used
check allocate status before deallocating
check the correct error return codes from subroutines

Resolves #40

RussTreadon-NOAA commented 5 months ago

Thank you @CoryMartin-NOAA for the quick review and approval.