fix a bug in deter_sfc_gmi (#778)

NOAA-EMC / GSI

Gridpoint Statistical Interpolation

GNU Lesser General Public License v3.0

66 stars 151 forks source link

fix a bug in deter_sfc_gmi (#778) #781

Closed xincjin-NOAA closed 3 months ago

xincjin-NOAA commented 3 months ago

Description

To fix a bug in deter_sfc_gmi which is dissed in detail in the issue #778 Debug gsi.x aborts in deter_sfc_gmi with invalid array index

changed a check for the subscript of an array.

Resolves #778

Type of change

Please delete options that are not relevant.

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] New and existing tests pass with my changes
[x] Any dependent changes have been merged and published

xincjin-NOAA commented 3 months ago

Passed ctest on Hera:


Test project /scratch1/NCEPDEV/da/Xin.C.Jin/GSI/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  1341.10 sec
2/6 Test #6: global_enkf ......................   Passed  2560.05 sec
3/6 Test #1: global_4denvar ...................   Passed  3304.88 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  3970.54 sec
5/6 Test #2: rtma .............................   Passed  4149.22 sec
6/6 Test #4: hafs_4denvar_glbens ..............   Passed  4374.31 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 4374.37 sec

RussTreadon-NOAA commented 3 months ago

The wrong fix is associated with the PR. We want fix @ 2a86d5b. I don't know how xincjin-NOAA:feature/deter_sfc_gmi wound up with fix @ 0be2697. Please update the fix hash to fix @ 2a86d5b

RussTreadon-NOAA commented 3 months ago

@xincjin-NOAA , would you please run the ctests on WCOSS2 (Cactus)?

xincjin-NOAA commented 3 months ago

@RussTreadon-NOAA

Ctest passed on WCOSS2 (Cactus):

Test project /lfs/h2/emc/da/noscrub/xin.c.jin/GSI/build
    Start 1: global_4denvar
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 2: rtma
    Start 6: global_enkf
    Start 3: rrfs_3denvar_rdasens
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  728.66 sec
2/6 Test #6: global_enkf ......................   Passed  916.55 sec
3/6 Test #2: rtma .............................   Passed  975.87 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  1297.47 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1299.56 sec
6/6 Test #1: global_4denvar ...................   Passed  1792.74 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 1792.86 sec

RussTreadon-NOAA commented 3 months ago

Thank you @xincjin-NOAA for running ctests on Cactus and Hera. This is sufficient. Once we get peer reviews and approvals we can submit this PR to the GSI Handling Review team for final approval.

RussTreadon-NOAA commented 3 months ago

Thank you @CatherineThomas-NOAA and @emilyhcliu for your reviews and approval.