search

NOAA-EMC / HAFS

Hurricane Analysis and Forecast System
5 stars 3 forks source link

hafs_utils fixes. #8

Closed hrwinterbottom closed 5 years ago

hrwinterbottom commented 5 years ago

This PR has bug fixes for hafs_utils/obs-to-bufr source code and documentation corrections for the module files required to compile the hafs_utils.

BinLiu-NOAA commented 5 years ago

Henry, Did you try compiling/building hafs_utils.fd on theia, wcosscray, and wcossdell? I believe the LIB and INC changes I made in the Makefiles were to make them work on these platforms. Thanks! Bin

hrwinterbottom commented 5 years ago

Henry, Did you try compiling/building hafs_utils.fd on theia, wcosscray, and wcossdell? I believe the LIB and INC changes I made in the Makefiles were to make them work on these platforms. Thanks! Bin

Bin: If the Makefiles changed, that shouldn't have happened. The only think that should have changed was bufrio_interface.F90 to fix some issues related to the more recent updates to the bufr libs on Jet. If I did make a mistake, I can fix this and just PR the single file. I have not tested on machines other than Jet, but I can. I caught this error at run-time, so it was not related to a compilation issue. Let me know.

Thanks.

-H

BinLiu-NOAA commented 5 years ago

Discussed with Henry and will pick up his bug fix for sorc/hafs_utils.fd/sorc/obs_to_bufr/bufrio_interface.F90 in another pull request. Closing this one.