NOAA-EMC / JEDI-T2O

JEDI Transition to Operations activities.
GNU Lesser General Public License v2.1
5 stars 4 forks source link

Merge feature/gdas-validation into develop #109

Closed RussTreadon-NOAA closed 8 months ago

RussTreadon-NOAA commented 8 months ago

As GDAS validation nears completion the need for a separate feature/gdas-validation diminishes. This PR brings updates in feature/gdas-validation into develop.

RussTreadon-NOAA commented 8 months ago

@CoryMartin-NOAA , @emilyhcliu , and @ADCollard : I created this PR as a draft because I don't know the answers to the following questions:

  1. Do we want to capture the changes in feature/gdas-validation into develop?
  2. If the answer to 1 is yes, is now the right time to merge feature/gdas-validation into develop?

Based on the answers to these questions, we can delete, pause, or move forward with this PR.

RussTreadon-NOAA commented 8 months ago

@emilyhcliu and @ADCollard : any thoughts on this PR? Keep and move forward or abandon?

emilyhcliu commented 8 months ago

@RussTreadon-NOAA Let's move forward and merge the feature/gdas-validation branch into the JEDI-T2O.

RussTreadon-NOAA commented 8 months ago

Thank you @emilyhcliu and @ADCollard for the green light. I changed this PR to open and will invite you to be reviewers.

RussTreadon-NOAA commented 8 months ago

Done! Thank you @emilyhcliu and @ADCollard for your approvals.

Developers should use JEDI-T2O develop. I do not plan on making any more updates to feature/gdas-validation. In fact at some point we should delete feature/gdas-validation. There's a button to do so in this PR.