NOAA-EMC / JEDI-T2O

JEDI Transition to Operations activities.
GNU Lesser General Public License v2.1
5 stars 4 forks source link

Evaluate/ Validate Pressure and Temperature QC Procedures in Sonde YAML File and GSI #41

Open PraveenKumar-NOAA opened 2 years ago

PraveenKumar-NOAA commented 2 years ago

A Sonde YAML file exists in GDASApp copied from UFO/ewok/jedi-gdas on June 28, 2022.

Before diving into replicating the PrepBUFR preprocessing for Sonde pressure and temperature observations, we should first check that the QC procedures implemented in UFO match those being performed in GSI on PrepBUFR observations.

This issue will be used to track progress, including figures, statistics, and paths to files.

PraveenKumar-NOAA commented 2 years ago

Using the sondes_ps.yaml, that Cory wrote, I ran GDASApp for the following observations: surface pressure, air temperature, specific humidity, and wind. Surface pressure plots are attached below that need to be discussed first: gsi_hofx_vs_jedi_hofx_2021080100_sondes_surface_pressure

This plot looks pretty good.

PraveenKumar-NOAA commented 2 years ago

hofxdiff_vs_pressure_2021080100_sondes_surface_pressure

This plot needs further discussion, as points are mostly scattered.

PraveenKumar-NOAA commented 2 years ago

gsi_hofx_vs_obs_2021080100_sondes_surface_pressure

jedi_hofx_vs_obs_2021080100_sondes_surface_pressure

Both plots look very similar.

PraveenKumar-NOAA commented 2 years ago

hofxdiff_histogram_2021080100_sondes_surface_pressure

errordiff_histogram_2021080100_sondes_surface_pressure

Histogram plots: one is centered at zero, but other one not.

CoryMartin-NOAA commented 2 years ago

I believe these differences can likely be resolved by https://github.com/JCSDA-internal/ufo/pull/2207

PraveenKumar-NOAA commented 2 years ago

Air_temperature plots: gsi_hofx_vs_jedi_hofx_2021080100_sondes_air_temperature

hofxdiff_vs_pressure_2021080100_sondes_air_temperature

gsi_hofx_vs_obs_2021080100_sondes_air_temperature

jedi_hofx_vs_obs_2021080100_sondes_air_temperature

Histograms: errordiff_histogram_2021080100_sondes_air_temperature

hofxdiff_histogram_2021080100_sondes_air_temperature

CoryMartin-NOAA commented 2 years ago

@PraveenKumar-NOAA something looks wrong here... is this a plotting issue or a data issue?

PraveenKumar-NOAA commented 2 years ago

@CoryMartin-NOAA most probably a data issue, I will look into the details.

CoryMartin-NOAA commented 2 years ago

@PraveenKumar-NOAA it looks like this is 'pressure' and not 'temperature', note that GSI is ~200-300 and JEDI is ~30000-100000 (K vs Pa)

PraveenKumar-NOAA commented 1 year ago

I believe these differences can likely be resolved by JCSDA-internal/ufo#2207

Created new surface pressure plots after the GSI Ps fix, which look similar to those created without this fix.

PraveenKumar-NOAA commented 1 year ago

@CoryMartin-NOAA @ADCollard @emilyhcliu there was an error in yaml for the air_temperarure. I fixed and regenerated air_temperature plots for H(x), error, histogram, etc. The plots look better compared to the old ones.

gsi_hofx_vs_jedi_hofx_2021080100_sondes_air_temperature

gsi_hofx_vs_obs_2021080100_sondes_air_temperature

gsi_omb_vs_jedi_omb_2021080100_sondes_air_temperature

hofxdiff_vs_qcdiff_2021080100_sondes_air_temperature

jedi_hofx_vs_obs_2021080100_sondes_air_temperature

hofxdiff_histogram_2021080100_sondes_air_temperature

errordiff_histogram_2021080100_sondes_air_temperature

CoryMartin-NOAA commented 1 year ago

Thanks @PraveenKumar-NOAA these look great. Can you do virtual_temperature next? The way the sondes input files are currently setup, air_temperature obs are only in the ~stratosphere (where there are no humidity obs) and virtual_temperature obs are in the troposphere.

PraveenKumar-NOAA commented 1 year ago

Thanks @PraveenKumar-NOAA these look great. Can you do virtual_temperature next? The way the sondes input files are currently setup, air_temperature obs are only in the ~stratosphere (where there are no humidity obs) and virtual_temperature obs are in the troposphere.

@CoryMartin-NOAA sure, thanks for the output.

PraveenKumar-NOAA commented 1 year ago

@CoryMartin-NOAA I ran GDASApp and generated virtual-temperature plots for the sonde data. I nned to discuss these plots with you.

gsi_hofx_vs_jedi_hofx_2021080100_sondes_virtual_temperature

gsi_hofx_vs_obs_2021080100_sondes_virtual_temperature

gsi_omb_vs_jedi_omb_2021080100_sondes_virtual_temperature

hofxdiff_vs_qcdiff_2021080100_sondes_virtual_temperature

jedi_hofx_vs_obs_2021080100_sondes_virtual_temperature

Histogram plots:

errordiff_histogram_2021080100_sondes_virtual_temperature

hofxdiff_histogram_2021080100_sondes_virtual_temperature

CoryMartin-NOAA commented 1 year ago

@PraveenKumar-NOAA Yikes, something looks bad here...

PraveenKumar-NOAA commented 1 year ago

Regenerated surface_pressure plots using the updated GDASApp and performed analysis on the output diag file:

Comparison of GSI and UFO H(x):

gsi_hofx_vs_jedi_hofx_2021080100_sondes_surface_pressure

hofxdiff_vs_qcdiff_2021080100_sondes_surface_pressure

Number of observations passing/failing quality control

Observation error assignment

errordiff_histogram_2021080100_sondes_surface_pressure

hofxdiff_histogram_2021080100_sondes_surface_pressure

PraveenKumar-NOAA commented 1 year ago

Updated results for the air_temperature obs. I only used PreQC for the air_temperature in my YAML and the results obtained are discussed below:

Comparison of GSI and UFO H(x):

gsi_hofx_vs_jedi_hofx_2021080100_sondes_air_temperaturehofxdiff_vs_qcdiff_2021080100_sondes_air_temperature

Number of observations passing/failing quality control

The total counts which passed QC in GSI are 15103 (GsiEffectiveQC=0), while for JEDI are 15108 (EffectiveQC=0). The totals are not the same between GsiEffectiveQC=1 and EffectiveQC!=0. The number of counts for GsiEffectiveQC=1 is 113 and for EffectiveQC!=0 is 62984.

Observation error assignment

The differences between the GsiFinalObsError and EffectiveError is also small, please look at the histogram plots below.

errordiff_histogram_2021080100_sondes_air_temperature hofxdiff_histogram_2021080100_sondes_air_temperature

PraveenKumar-NOAA commented 1 year ago

The number of observations that passed QCs is listed in the following document, https://docs.google.com/document/d/1_w6P-cJkxyYzTvLNMm6kCBWj2ZATk0PMsXOdKW29z8s/edit for three different YAML: