search

NOAA-EMC / MOM6

Modular Ocean Model
Other
0 stars 15 forks source link

update MOM6 to its main 20231218 commit (disable FPEs) #124

Closed jiandewang closed 10 months ago

jiandewang commented 10 months ago

MOM6 main repository was updated on 20231218 to fix FPEs bug in its CI test. (see detail at https://github.com/mom-ocean/MOM6/pull/1617). This is a very simple PR with no any resuls change. Related dev/emc MOM6 issue is #123. We need to have this being merged to dev/emc before we can create PR to push @DeniseWorthen work back to main repository.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a36cb73) 37.91% compared to head (9926fc2) 37.91%.

:exclamation: Current head 9926fc2 differs from pull request most recent head db62734. Consider uploading reports for the commit db62734 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/emc #124 +/- ## ======================================== Coverage 37.91% 37.91% ======================================== Files 269 269 Lines 77155 77089 -66 Branches 14164 14154 -10 ======================================== - Hits 29252 29230 -22 + Misses 42625 42582 -43 + Partials 5278 5277 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jiandewang commented 10 months ago

@DeniseWorthen @JessicaMeixner-NOAA can you review this PR ?

jkbk2004 commented 10 months ago

Tests are done at https://github.com/ufs-community/ufs-weather-model/pull/2080. @DeniseWorthen @JessicaMeixner-NOAA can you merge this pr?

JessicaMeixner-NOAA commented 10 months ago

@jiandewang can you do the merge?

jiandewang commented 10 months ago

just merged