NOAA-EMC / MOM6

Modular Ocean Model
Other
0 stars 15 forks source link

update to main 20240228 commit #127

Closed jiandewang closed 8 months ago

jiandewang commented 8 months ago

This is a big PR which originally was GFDL 20231113 candidate PR (https://github.com/mom-ocean/MOM6/pull/1616). The original PR failed to retain UFS BL on wcoss2 but are fine on all other platforms. With Marshall and Bob's further modification, it can retain UFS BL on wcoss2 for 1x1, half and quarter degree settings now. Discussion on the root cause of the original failing of retain BL can be found in the original PR (https://github.com/mom-ocean/MOM6/pull/1616) and the last commit from Marshall in ths PR. new BL are needed for:

note the original DEFAULT_2018_ANSWERS=T has changed to DEFAULT_ANSWER_DATE=20181231 in MOM_input

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 24.13651% with 1845 lines in your changes are missing coverage. Please review.

Project coverage is 37.45%. Comparing base (c8a7325) to head (e3ae82b).

:exclamation: Current head e3ae82b differs from pull request most recent head 2ab885e. Consider uploading reports for the commit 2ab885e to get more accurate results

Files Patch % Lines
src/parameterizations/lateral/MOM_Zanna_Bolton.F90 1.07% 277 Missing :warning:
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% 237 Missing :warning:
src/diagnostics/MOM_wave_speed.F90 22.68% 173 Missing and 11 partials :warning:
src/core/MOM_interface_heights.F90 13.72% 130 Missing and 2 partials :warning:
src/core/MOM_forcing_type.F90 18.04% 99 Missing and 10 partials :warning:
src/core/MOM.F90 39.43% 61 Missing and 25 partials :warning:
src/ice_shelf/MOM_ice_shelf.F90 0.00% 75 Missing :warning:
src/core/MOM_barotropic.F90 56.75% 46 Missing and 18 partials :warning:
src/core/MOM_open_boundary.F90 33.33% 53 Missing and 7 partials :warning:
src/ALE/MOM_ALE.F90 40.65% 45 Missing and 9 partials :warning:
... and 41 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/emc #127 +/- ## =========================================== - Coverage 47.21% 37.45% -9.76% =========================================== Files 41 270 +229 Lines 4575 79765 +75190 Branches 805 14833 +14028 =========================================== + Hits 2160 29878 +27718 - Misses 2234 44350 +42116 - Partials 181 5537 +5356 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zach1221 commented 8 months ago

Hello, @DeniseWorthen and @JessicaMeixner-NOAA , this PR is now ready for review.

jiandewang commented 8 months ago

got greenlight from two reviewers now.

zach1221 commented 8 months ago

@jiandewang regression testing is complete on 2166, and we can begin the final review/merge process. Can you please merge this MOM6 PR for us?

jiandewang commented 8 months ago

just merged