Closed jiandewang closed 8 months ago
Attention: Patch coverage is 24.13651%
with 1845 lines
in your changes are missing coverage. Please review.
Project coverage is 37.45%. Comparing base (
c8a7325
) to head (e3ae82b
).:exclamation: Current head e3ae82b differs from pull request most recent head 2ab885e. Consider uploading reports for the commit 2ab885e to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello, @DeniseWorthen and @JessicaMeixner-NOAA , this PR is now ready for review.
got greenlight from two reviewers now.
@jiandewang regression testing is complete on 2166, and we can begin the final review/merge process. Can you please merge this MOM6 PR for us?
just merged
This is a big PR which originally was GFDL 20231113 candidate PR (https://github.com/mom-ocean/MOM6/pull/1616). The original PR failed to retain UFS BL on wcoss2 but are fine on all other platforms. With Marshall and Bob's further modification, it can retain UFS BL on wcoss2 for 1x1, half and quarter degree settings now. Discussion on the root cause of the original failing of retain BL can be found in the original PR (https://github.com/mom-ocean/MOM6/pull/1616) and the last commit from Marshall in ths PR. new BL are needed for:
note the original DEFAULT_2018_ANSWERS=T has changed to DEFAULT_ANSWER_DATE=20181231 in MOM_input