codecov-commenter
commented
8 months ago Codecov Report
Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.
Project coverage is 37.44%. Comparing base (
10521a9) to head (f10ef1b).:exclamation: Current head f10ef1b differs from pull request most recent head dc24883. Consider uploading reports for the commit dc24883 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev/emc #130 +/- ## =========================================== - Coverage 37.45% 37.44% -0.02% =========================================== Files 270 270 Lines 79765 79800 +35 Branches 14833 14833 =========================================== Hits 29878 29878 - Misses 44350 44385 +35 Partials 5537 5537 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
zach1221
jiandewang
This patch clears out many errors detected by Intel Fortran.
Most are false positives from stub functions which would normally be replaced in production and report unset output. These variables are now assigned dummy values in order to pacify the compiler.
The
statfunction in POSIX was incorrectly passing itsbufobject to the Cstatfunction asintent(in), causing the compiler to believe that the contents were unset. Oddly, this was already working correctly, and perhaps warrants further investigation, but it has now been correctly set tointent(inout).The
ppoly_*variables incheck_reconstruction_1dappear to have been incorrectly declared asout, when they are clearly used asinto validate the values. This has been corrected.register_diag_fieldin the ice shelf diag manager was incorrectly declared and the function appeared to return nothing. Perhaps this function was not used for anything.An IO statement in MOM_open_boundary had a syntax error; this has been fixed.
get_datasetreturns adataset_type, so some compilers expect the stub function to also return a validdataset. Since the stubdataset_typecontains no fields, any locally declared instance should be sufficient as a return value.