search

NOAA-EMC / NCEPLIBS-bacio

This library performs binary I/O for the NCEP models.
Other
2 stars 6 forks source link

CMAKE_INSTALL_DESTINATION contains "lib" instead of ${CMAKE_INSTALL_LIBDIR} #112

Closed edwardhartnett closed 1 year ago

edwardhartnett commented 1 year ago

See https://github.com/NOAA-EMC/NCEPLIBS-w3emc/issues/146 for details.

edwardhartnett commented 1 year ago

@aerorahul and @AlexanderRichert-NOAA all discussion of bacio can happen in this issue...

We currently have the following in src/CMakeLists.txt:

install(
  TARGETS ${LIB_TARGETS}
  EXPORT ${PROJECT_NAME}Exports
  RUNTIME DESTINATION bin
  LIBRARY DESTINATION lib
  ARCHIVE DESTINATION lib)

### Package config
include(CMakePackageConfigHelpers)
set(CONFIG_INSTALL_DESTINATION lib/cmake/${PROJECT_NAME})

So I think we want to change "lib/" to CMAKE_INSTALL_LIBDIR everywhere, including the package config.

I am also thinking we should be using CMAKE_INSTALL_BINDIR instead of bin.

edwardhartnett commented 1 year ago

I have made the above changes in the open PR #113