removed unused code - Githubissues

NOAA-EMC / NCEPLIBS-bacio

This library performs binary I/O for the NCEP models.

Other

2 stars 6 forks source link

Closed edwardhartnett closed 3 years ago

edwardhartnett commented 3 years ago

Fixes #53

Remove the unused banio functions.

BrianCurtis-NOAA commented 3 years ago

Why is *size getting removed ? Was it always 1? If it wasn't I am just guessing it would change the number a bit and shouldn't be removed.

edwardhartnett commented 3 years ago

Actually what is happening is that the github output is confusing.

There were four functions in the file, all almost identical.

bacio banio baciol baniol

I removed banio and baniol, and it seems to be showing that as if I made a bunch of changes in baniol.

Take a look at the whole file and you will see that bacio/baciol are untouched, and banio/baniol are gone.

BrianCurtis-NOAA commented 3 years ago

Thanks for that pointer. To code was so similar the diff threw me off.