search

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.
Other
44 stars 19 forks source link

documentation, more testing for adn30()/idn30(), changes in gcovr output #388

Closed edwardhartnett closed 1 year ago

edwardhartnett commented 1 year ago

Fixes #389

Some documentation fixes, adding tests for adn30()/idn30() to bring them to full testing.

Also some changes to the gcovr run, adding some new parameters, which results in better tracking of branches testes, and a new column, "decisions", which is supposed to better help us ensure that all decisions are fully covered. We'll have to use this a bit to see how it helps.

See https://gcovr.com/en/stable/faq.html for info about the new gcovr options.

edwardhartnett commented 1 year ago

Can we merge this before our meeting this afternoon?

jbathegit commented 1 year ago

OK, I can do that, but first could you please push up another commit to make the remarks in the arallocf docblock the same as the changes you've now made to the remarks in the arallocc docblock? I think these should stay consistent, and I asked about this earlier, but I can certainly understand if it got lost in the shuffle of all of the other discussion we've been having ;-)

Once that's done, I'll approve and merge it, and then I'll be following right behind with a PR of my own that's now ready for you to look at for a number of the utility codes in #376 ;-) The timing will be good b/c I have changes of my own to test/CMakeLists.txt that I can merge on top of yours.