Closed edwardhartnett closed 1 year ago
@jbathegit I suggest you take a look at this before making any more code changes.
For example, without the -w flag, we find you just introduced a new set of warnings:
/home/runner/work/NCEPLIBS-bufr/NCEPLIBS-bufr/bufr/src/bufr_interface.F90:18:23:
18 | subroutine cobfl_c( bfl, io ) bind(C, name='cobfl')
| 1
Error: Variable ‘bfl’ at (1) is a dummy argument of the BIND(C) procedure ‘cobfl_c’ but may not be C interoperable [-Werror=c-binding-type]
/home/runner/work/NCEPLIBS-bufr/NCEPLIBS-bufr/bufr/src/bufr_interface.F90:18:27:
18 | subroutine cobfl_c( bfl, io ) bind(C, name='cobfl')
| 1
Error: Variable ‘io’ at (1) is a dummy argument of the BIND(C) procedure ‘cobfl_c’ but may not be C interoperable [-Werror=c-binding-type]
/home/runner/work/NCEPLIBS-bufr/NCEPLIBS-bufr/bufr/src/bufr_interface.F90:33:23:
33 | subroutine crbmg_c( bmg, mxmb, nmb, iret ) bind(C, name='crbmg')
| 1
Error: Variable ‘bmg’ at (1) is a dummy argument of the BIND(C) procedure ‘crbmg_c’ but may not be C interoperable [-Werror=c-binding-type]
/home/runner/work/NCEPLIBS-bufr/NCEPLIBS-bufr/bufr/src/bufr_interface.F90:48:23:
48 | subroutine cwbmg_c( bmg, nmb, iret ) bind(C, name='cwbmg')
| 1
Error: Variable ‘bmg’ at (1) is a dummy argument of the BIND(C) procedure ‘cwbmg_c’ but may not be C interoperable [-Werror=c-binding-type]
Let's get the -w flag turned off before we do any more code changes.
I'll take this down. Jeff is addressing these warnings in #436 and other PRs.
When I remove the -w flag, we get a bunch of Fortran warnings.