update strnum to handle valx functionality, and remove valx

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.

Other

44 stars 19 forks source link

update strnum to handle valx functionality, and remove valx #406

Closed jbathegit closed 1 year ago

jbathegit commented 1 year ago

Fixes #369 Fixes #407

Part of #254 Part of #300

edwardhartnett commented 1 year ago

This is a solid improvement. I suggest you merge this and we continue discussions in #369.

Removing valx() is a great thing.

jbathegit commented 1 year ago

OK, I'll do that, and I see you've now closed #409. But I'll still follow up with another PR of my own which follows your advice in #409, and which cleans up strnum.F90 even further and moves the testing for some of those oddball cases from intest7.F90 to test_misc.F90, like you demonstrated.

I'll do that tomorrow morning...