search

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.
Other
44 stars 19 forks source link

atrcpt testing #411

Closed AlexanderRichert-NOAA closed 1 year ago

AlexanderRichert-NOAA commented 1 year ago

Setting up a draft PR for adding 8-byte testing for atrcpt.

Fixes #347

AlexanderRichert-NOAA commented 1 year ago

@jbathegit I could use some guidance here. I think that as with the previous test I added, the idea is to add a call to the subroutine (in this case atrcpt) directly in a test program after setim8b has been called. I think the main issue here is that I don't know what outcome I'm looking for. Should I be looking for certain values in my modified bufr message, or should I be content that this runs without anything crashing?

jbathegit commented 1 year ago

Hi Alex, did you see any of my earlier comments from last Friday? It doesn't look like you've made any such updates.

For example, this new test should have a "stop 6" instead of "stop 3", and you shouldn't pass the same array as the 1st (input) and 3rd (output) arguments to atrcpt().

AlexanderRichert-NOAA commented 1 year ago

Hi Alex, did you see any of my earlier comments from last Friday? It doesn't look like you've made any such updates.

For example, this new test should have a "stop 6" instead of "stop 3", and you shouldn't pass the same array as the 1st (input) and 3rd (output) arguments to atrcpt().

I don't see any comments from you on this PR if that's what you mean. Any chance you wrote a review but didn't complete it?

I fixed the two items you mentioned.

jbathegit commented 1 year ago

Hmm, that's weird, I've commented on a lot of PRs in the past, but I've never had to explicitly click "Send" before!? I must have gotten into some strange window when I did those comments, b/c looking back I see they all still had a Pending label on them!?

Anyway, I've just re-posted, and hopefully you can see them now. Sorry about that!

jbathegit commented 1 year ago

The only comment I just added now was the one about "stop 7" vs. "stop 6". The others I had originally tried to send on Friday.