search

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.
Other
44 stars 19 forks source link

more testing for mtfnam #502

Closed jbathegit closed 1 year ago

jbathegit commented 1 year ago

Part of #445

jack-woollen commented 1 year ago

Jeff

I just got this from cloning/compiling a bufrlib branch on wc2.

/lfs/h2/emc/global/noscrub/Jack.Woollen/cris-fix/NCEPLIBS-bufr/test/test_misc.F90(207): error #6345: Either a PAUSE, STOP or ERROR STOP statement has an invalid argument. if ( (iret .ne. 0) .or. (igetprm(trim(prms(i))) .ne. 42+i) ) stop 800+i

It doesn't like stop 800+i !

Jack

On Wed, May 24, 2023 at 3:18 PM Jeff Ator @.***> wrote:

Merged #502 https://github.com/NOAA-EMC/NCEPLIBS-bufr/pull/502 into develop.

— Reply to this email directly, view it on GitHub https://github.com/NOAA-EMC/NCEPLIBS-bufr/pull/502#event-9331773117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3XO6JOI2DV7TEYWNXCJSLXHZNH3ANCNFSM6AAAAAAYNQH33A . You are receiving this because your review was requested.Message ID: @.***>

AlexanderRichert-NOAA commented 1 year ago

Ah dang it, that was me. I forgot some compilers/fortran versions don't like that. I'm looking at this file right now so I'll fix it while I'm at it.

jbathegit commented 1 year ago

Hey Jack, just curious - what compiler were you trying to use on WC2? If it was the Intel compiler, then it's surprising that this hasn't already cropped up during the GitHub CI runner testing.

In short, I agree we need to get this fixed, but just wondering why it never showed up in the CI test for Intel? More of a curiosity as much as anything.