search

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.
Other
42 stars 19 forks source link

Make python component part of build, not install #524

Closed AlexanderRichert-NOAA closed 10 months ago

AlexanderRichert-NOAA commented 10 months ago

Proposing a solution for #520, which is to make the python module build part of the build step, not the install step. This PR rearranges python/CMakeLists.txt to use a new target called "python_mod", with which a custom build command can be run to take care of the setup.py invocation. With these changes, setup.py "installs" into the build space, then that directory is copied to the appropriate location by "make install". I took out the first of the two "python setup.py build" invocations because it didn't seem to be necessary but I can reinstate if needed.

climbfuji commented 10 months ago

I am removing myself from the list of reviewers (but appreciate the heads up), because I don't really know enough about the NCEPLIBS-bufr code.

climbfuji commented 10 months ago

I am removing myself from the list of reviewers (but appreciate the heads up), because I don't really know enough about the NCEPLIBS-bufr code.

Well, I would if I could ;-)

aerorahul commented 10 months ago

I am removing myself from the list of reviewers (but appreciate the heads up), because I don't really know enough about the NCEPLIBS-bufr code.

Well, I would if I could ;-)

boo. there is nothing to know about the bufr code here. its just regular cmake and installation stuff.

climbfuji commented 10 months ago

I am removing myself from the list of reviewers (but appreciate the heads up), because I don't really know enough about the NCEPLIBS-bufr code.

Well, I would if I could ;-)

boo. there is nothing to know about the bufr code here. its just regular cmake and installation stuff.

Just needed an excuse for not having the time ...

jbathegit commented 10 months ago

Thanks Alex and Rahul!