search

NOAA-EMC / NCEPLIBS-bufr

The NCEPLIBS-bufr library contains routines and utilites for working with the WMO BUFR format.
Other
46 stars 22 forks source link

increase maximum message size in debufr utility #630

Closed jbathegit closed 3 weeks ago

jbathegit commented 3 weeks ago

Also relocated an initialization loop to improve runtime efficiency, per discussion in #625

Also cleaned up an address sanitizer issue that had been showing up in the developer runner for subroutine rewnbf

AlexanderRichert-NOAA commented 3 weeks ago

Is there a corresponding issue for the message length change?

jbathegit commented 3 weeks ago

Is there a corresponding issue for the message length change?

No I didn't write one up b/c it was literally a one-line change, and it came about b/c of an email from a WCOSS2 user who was having trouble using debufr to read through a file. As I looked into the issue it became clear it was because some of the messages the user was trying to read were upwards of 4Mb in size, and the utility previously had an upper limit of 2.5Mb.

jbathegit commented 3 weeks ago

Hi @AlexanderRichert-NOAA @jack-woollen @edwardhartnett

Are there any remaining comments or concerns about this PR? If not, could someone please approve it so I can go ahead and merge it?

(Thanks! :-)